-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ffmpeg_2: mark as insecure #120582
Merged
Merged
ffmpeg_2: mark as insecure #120582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajs124
reviewed
Apr 26, 2021
5c45cb8
to
2a13167
Compare
Does ultrastardx still work with ffmpeg3? |
I was able to build and run it. It played some sounds but I didn't test any functionality. |
SuperSandro2000
approved these changes
Apr 30, 2021
lukegb
reviewed
May 1, 2021
lukegb
approved these changes
May 2, 2021
backport: #121908 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1.severity: security
Issues which raise a security issue, or PRs that fix one
8.has: clean-up
8.has: port to stable
A PR already has a backport to the stable release.
9.needs: maintainer
Package or module needs active maintainers
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 11-100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It's outdated and insecure.
closes #93984 and closes #120371
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)I did not test whether the packages actually still work, just whether they build and run.
Two packages remain:
stepmania
might compile with a newer Ffmpeg if we use a more recent revision (no release made though) or with the vendored Ffmpeg. cc @RubenAstudilloPackage needs a new maintainer.
pcsxr
should also work if updated to 1.9.95. See https://aur.archlinux.org/packages/pcsxr. I gave it a try but stopped after some complications. cc @rardiol