Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg_2: mark as insecure #120582

Merged
merged 6 commits into from
May 6, 2021
Merged

ffmpeg_2: mark as insecure #120582

merged 6 commits into from
May 6, 2021

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Apr 25, 2021

Motivation for this change

It's outdated and insecure.
closes #93984 and closes #120371

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I did not test whether the packages actually still work, just whether they build and run.

Two packages remain:

  • stepmania might compile with a newer Ffmpeg if we use a more recent revision (no release made though) or with the vendored Ffmpeg. cc @RubenAstudillo
    Package needs a new maintainer.
  • pcsxr should also work if updated to 1.9.95. See https://aur.archlinux.org/packages/pcsxr. I gave it a try but stopped after some complications. cc @rardiol

@ofborg ofborg bot requested review from Profpatsch and ehmry April 25, 2021 09:46
@FRidh FRidh added this to the 21.05 milestone Apr 25, 2021
@dotlambda dotlambda added 1.severity: security Issues which raise a security issue, or PRs that fix one 9.needs: maintainer Package or module needs active maintainers labels Apr 25, 2021
@Profpatsch
Copy link
Member

Does ultrastardx still work with ffmpeg3?

@dotlambda
Copy link
Member Author

Does ultrastardx still work with ffmpeg3?

I was able to build and run it. It played some sounds but I didn't test any functionality.
However, we are also trying to get rid of ffmpeg_3: #120705

@dotlambda dotlambda marked this pull request as ready for review April 30, 2021 14:33
@dotlambda dotlambda changed the title ffmpeg_2: drop ffmpeg_2: mark as insecure Apr 30, 2021
@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label May 4, 2021
@dotlambda dotlambda merged commit bda9e19 into NixOS:master May 6, 2021
@dotlambda dotlambda deleted the ffmpeg_2-drop branch May 6, 2021 11:51
@dotlambda
Copy link
Member Author

backport: #121908

@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: clean-up 8.has: port to stable A PR already has a backport to the stable release. 9.needs: maintainer Package or module needs active maintainers 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100
Projects
None yet
7 participants