-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
flake: Bump nixpkgs to 25.11 #14688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
flake: Bump nixpkgs to 25.11 #14688
Conversation
5346510 to
28db0e0
Compare
|
Nixpkgs changed so that When I tried to fix that by setting The It seems like this is no longer working. I am also seeing structuredAttrs is incompatible with Things I haven't been able to figure out:
|
28db0e0 to
b79b527
Compare
|
This update also seems to make clangd dysfunctional. Still investingating... |
|
I can reproduce the (pkgs.hello.overrideAttrs {
__structuredAttrs = true;
}).inputDerivationThis complains about the output not being allowed to refer to output paths. I was suspicious of let
__structuredAttrs = true;
in
derivation ({
inherit __structuredAttrs;
system = "x86_64-linux";
name = "test";
outputs = [ "out" ];
builder = pkgs.stdenv.shell;
args = [
"-c"
''
out="${placeholder "out"}"
echo "$out" > $out
''
];
} // (
let
sharedOutputChecks = {
allowedReferences = null;
};
in
if __structuredAttrs then
{
outputChecks.out = sharedOutputChecks;
}
else
sharedOutputChecks
)
)And it does give the same error! ...But also it gives the same error when |
|
Created a Hydra jobset for this: https://hydra.nixos.org/jobset/nix/pr-14688 |
|
Error we're talking about: |
foo.nix{
hello_structured_attrs_input_drv = (pkgs.hello.overrideAttrs {
__structuredAttrs = true;
}).inputDerivation;
hello_normal_input_drv = pkgs.hello.inputDerivation;
custom_structured_attrs = derivation {
__structuredAttrs = true;
system = "x86_64-linux";
name = "test";
outputs = [ "out" ];
builder = pkgs.stdenv.shell;
args = [
"-c"
''
out="${placeholder "out"}"
echo "$out" > $out
''
];
outputChecks.out = {
allowedReferences = null;
allowedRequisites = null;
disallowedReferences = [ ];
disallowedRequisites = [ ];
};
};
custom_normal = derivation {
system = "x86_64-linux";
name = "test";
outputs = [ "out" ];
builder = pkgs.stdenv.shell;
args = [
"-c"
''
out="${placeholder "out"}"
echo "$out" > $out
''
];
allowedReferences = null;
allowedRequisites = null;
disallowedReferences = [ ];
disallowedRequisites = [ ];
};
}nix-build commands & outputnix-instantiate commands & output |
|
Note that By contrast |
|
For now we could do |
|
Adding |
|
Ooooooh. I was putting it in the wrong place. In any case, But this also means that, apparently, it only applies to top-level attributes not to |
f6c0c11 to
cb4d246
Compare
|
I've temporarily switched us to |
|
@Radvendii I think the remaining failures are due to incorrect versions for the "skip if daemon older than" conditions. It is not hard for this thing to happen. I would guess that the functional test failures we have no were not succeeding before, but skipped before. |
|
That makes sense for the #13247 test (should we open a new issue for that being broken?) The other errors come from |
b15d412 to
358f7c5
Compare
| if isDaemonNewer "2.29pre"; then | ||
| if isDaemonNewer "2.31"; then | ||
| <<<"$out" grepQuiet -E "error: Cannot build '.*-x4\\.drv'" | ||
| <<<"$out" grepQuiet -E "Reason: 1 dependency failed." | ||
| elif isDaemonNewer "2.29pre"; then | ||
| <<<"$out" grepQuiet -E "error: Cannot build '.*-x4\\.drv'" | ||
| <<<"$out" grepQuiet -E "Reason: 1 dependency failed." | ||
| <<<"$out" grepQuiet -E "Build failed due to failed dependency" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should I remove the last line from the isDaemonNewer "2.29pre" branch instead?
358f7c5 to
c9b1f16
Compare
7d35ba6 to
1ece7b5
Compare
|
Made this because big Hydra is overwhelmed right now: https://hydra.nixos-cuda.org/jobset/nix/PR14688 |
da70bd6 to
d8c73be
Compare
We don't want too much unnecessary formatting churn.
`mc config host add` has been removed SEE: minio/mc#5206
fixed in nixpkgs PR #469652
new version of meson creates some state file
nixpkgs 25.11 dropped support for nix 2.3. but we still want it to test against. We could get it from a more recent nixpkgs, but it seems better not to add more nixpkgs versions as dependencies.
d8c73be to
82cad21
Compare
82cad21 to
29fef75
Compare
|
It's failing to cross-compile nix to windows. It complains about Did |
|
I dont think we are blocking on the windows builds at this point. But @Eveeifyeve might have more information? |
Are you doing builds on cygwin? We only have support for cygwin officially as of right now... CC @corngood for potential cygwin issue. |
|
The numbers look much better on the big Hydra now: |
|
Also freebsd as broken on master, fix send a PR to fix it. |
|
For reference, you can view jobsets like |
There's no Cygwin in the hydra jobset. It's the mingw dependencies that are borked. I already fixed readline, but libcurl needs some massaging. We can probably just disable H2/H3 support and stick with an H1-only build of curl. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Btw the readline fix is in NixOS/nixpkgs#472232 |
There isn't a jobset yet but this is looking promising: NixOS/nixpkgs#475998 |
Motivation
25.11 is out and we should follow suit.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.