Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libutil/terminal): require both stderr/stdout to be tty to output color #11994

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(libutil/terminal): require both stderr/stdout to be tty to output color #11994

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libutil/terminal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ bool isTTY()
{
static const bool tty =
isatty(STDERR_FILENO)
&& isatty(STDOUT_FILENO)
Copy link
Member

@Mic92 Mic92 Dec 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only caveat I see just now is that we have tooling like cachix (maybe also attic?), will no have less fancy builds logs:

nix-build | cachix push

Also was nix-build output maybe not relying on this.

&& getEnv("TERM").value_or("dumb") != "dumb"
&& !(getEnv("NO_COLOR").has_value() || getEnv("NOCOLOR").has_value());

Expand Down
Loading