Add remove button (trash) on maintainers + small refactor #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannham
force-pushed
the
yannham/remove-maintainer-from-draft
branch
from
4c8334c to
055aeb7
Compare
Collaborator
|
Code looks pretty good from a cursory glance, I'll try it out soon(tm). But let's not add broken UI. Let's either skip displaying the new thing and keep it a pure refactor for now, or add the logic already. :) |
yannham
force-pushed
the
yannham/remove-maintainer-from-draft
branch
from
055aeb7 to
949fdd4
Compare
Contributor
Author
|
It was mostly for review purpose (small PR) that I split the two, but I can merge this PR and the next one - I'm confident the backend part of it will be relatively small. |
| padding: 0; | ||
| } | ||
|
|
||
| .maintainer-container input:not(:checked) ~ article { |
Collaborator
There was a problem hiding this comment.
Suggested change
| .maintainer-container input:not(:checked) ~ article { | |
| .maintainer-container input:not(:checked) ~ article, | |
| .maintainer-container input:not(:checked) ~ article a.github-id | |
| { |
So the handle also gets greyed out
1 task
Collaborator
|
Superseded by #558 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #553. This PR refactors the components displaying the list of maintainers by having a dedicated
maintainertemplate (instead of inlining this logic in themaintainer_list), and makes it possible to have the trash button (selectable). We also avoid having selectable and non-selectable version of the same component (that is, nixpkgs packages and the newly added maintainer) in two separate file, but rather use a context boolean, which deduplicates a bit of code.Note that nothing is properly handling the form if you click on the trash button for a maintainer; this is planned as future work.