refactor: structured configuration for allauth #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a bit more than merely a refactoring: now you can override the entire configuration from outside (e.g. using Nix attrsets) without touching secret values. also the type declaration allows inferring the shape of allowed values without having to check allauth documentation.
Erethon
approved these changes
May 21, 2025
Collaborator
Erethon
left a comment
Erethon
left a comment
There was a problem hiding this comment.
LGTM on a cursory look, but haven't actually tested/run this. Approving and leaving the merge up to you @fricklerhandwerk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #464
this is a bit more than merely a refactoring: now you can override the
entire configuration from outside (e.g. using Nix attrsets) without
touching secret values.
also the type declaration allows inferring the shape of allowed values
without having to check allauth documentation.