-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dns: prepare Gandi migration #616
base: main
Are you sure you want to change the base?
Conversation
ALIAS at the domain apex, CNAME for everything else.
fdfd01c
to
a4a6451
Compare
Looks like it needs more changes on the Gandi end:
|
@@ -23,6 +23,7 @@ jobs: | |||
- uses: cachix/install-nix-action@d1ca217b388ee87b2507a9a93bf01368bde7cec2 # v31 | |||
- name: dnscontrol push | |||
env: | |||
GANDI_TOKEN: "${{ secrets.GANDI_TOKEN }}" # Expires 2026-04-07 | |||
NETLIFY_TOKEN: "${{ secrets.NETLIFY_TOKEN }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I'm assuming it'll work find to deploy to netlify and gandi in parallel). Suggestion: consider adding a TODO/issue to remind us to clean up netlify (not just this code, but the old dns entries in netlify to avoid confusion).
@@ -171,7 +172,11 @@ D("nixos.org", | |||
TXT("_github-pages-challenge-nixos", "f3a423ba6916e972cfb1e74f82f601"), | |||
|
|||
// netlify pages | |||
ALIAS("@", "nixos-homepage.netlify.app."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies if you explained this elsewhere: is this violating the advice from https://answers.netlify.com/t/support-guide-which-are-some-good-dns-providers-for-alias-aname-support/211?
Some providers we cannot recommend after last review (which is well over 2 years ago at this point) are ALIAS or ANAME records provided by folks like Hover, DNS Made Easy, and even NS1 when not used as a service we provide: those “fancy” record types as implemented at those providers hosting was at last review incompatible with the way we do GeoIP routing for our CDN.
Granted, this post from 2019 sounds a bit hand wavy about a "review" they did in 2017.
@@ -171,7 +172,11 @@ D("nixos.org", | |||
TXT("_github-pages-challenge-nixos", "f3a423ba6916e972cfb1e74f82f601"), | |||
|
|||
// netlify pages | |||
ALIAS("@", "nixos-homepage.netlify.app."), | |||
CNAME("common-styles", "nixos-common-styles.netlify.app."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these CNAMEs (and the ALAIAS record above) going to apply cleanly to netlify (which, IIUC, we're still deploying to with the changes in this PR)?
ALIAS at the domain apex, CNAME for everything else.