Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
==========================================
+ Coverage 98.56% 98.57% +0.01%
==========================================
Files 32 32
Lines 3547 3579 +32
==========================================
+ Hits 3496 3528 +32
Misses 51 51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
cursor_pull_request_303_review.md Please look at the issues pointed and fix them |
Thanks for this review, Ashok! I looked over the feedback and I think that it can all be added to a follow-up improvement ticket. Although some of the callouts are described as bugs I'd argue that nothing is actually broken with the code the PR introduces, just perhaps not as pretty or clear as it could be. But please let me know if there are specific points in your feedback that you'd say absolutely need to be addressed for this PR and could not be added as a follow-up. |
I made a new issue to track this! #306 |
Description
When using Databricks serverless compute, ANSI mode is on by default, which enforces stricter standards on some SQL commands, one of which is stricter casting behavior.
This PR
Related Issue
#304
Motivation and Context
See above. Enables casting in Spark Expectations to be ANSI-compliant.
How Has This Been Tested?
Added new unit tests & ran
Types of changes
Checklist: