Laminar Flame Speed Functionality Addition #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cailinmoore
commented
May 1, 2022
cailinmoore
commented
- Added functionality to use laminar flame speed for model reduction
- Added flame simulation file and modified existing files to work with laminar flame option
- Added functionality to test flame additions
|
Is this pull request fully working? (apart from documentation...) |
This did work when it was submitted, but I've been holding off on merging because I'm in the middle of some major updates to pyMARS, including making it compatible with Cantera 2.6, and also replacing the CI dependence on Travis. |
|
@kyleniemeyer, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.