Added TypeScript support + improvement to generated files#56
Added TypeScript support + improvement to generated files#56cervantes-x wants to merge 3 commits intoNielsLeenheer:mainfrom
Conversation
- removed center from table verticalAlign
|
Could we maybe get an approval for this @NielsLeenheer? |
|
Can it be merged soon? |
|
i am also waiting for this. |
|
Also waiting here |
The implementation in LineComposer already handles center alignment for embedded mode (tables/boxes), but the documentation only listed left and right as valid options. Update docs to include center. Extracted from PR #56. https://claude.ai/code/session_01D7JHMJTJhD4TNqqhrwS3Qr
|
Sorry this took so long. The PR did help with making clear what the result should be, but I did have some issues with how we got to that result. Mostly with adding a separate type def file that needs to be kept in sync, the generated files containing data and not being integrated in the build system. So I've now added .d.ts support in the main repository by generating only the allowed values, and letting tsc generate the .d.ts file itself from the js. That makes it a lot more manageable. Also added it upstream to the codepage encoder so we can import those values straight from there. So the upcoming release will include property type definitions. |
7 participants
Had to close my previous PR because of some issues.
This PR includes the following changes: