feat: limit orders contract #1287
Conversation
MilGard91
force-pushed
the
feat/limit-orders
branch
from
776621f to
781f4b7
Compare
|
relates to #1249 |
MilGard91
force-pushed
the
feat/limit-orders
branch
6 times, most recently
from
e05b18f to
bccbe5a
Compare
shark0der
changed the title
MilGard91
force-pushed
the
feat/limit-orders
branch
3 times, most recently
from
a8e3bde to
9fdbb38
Compare
MilGard91
force-pushed
the
feat/limit-orders
branch
from
d01c197 to
ceac2ed
Compare
MilGard91
force-pushed
the
feat/limit-orders
branch
from
99263e7 to
a844715
Compare
| @@ -2,10 +2,12 @@ | |||
|
|
|||
| pragma solidity ^0.8.18; | |||
| import "../../generic/CoverGeneric.sol"; | |||
| import "hardhat/console.sol"; | |||
| @@ -467,7 +471,7 @@ contract Cover is ICover, MasterAwareV2, IStakingPoolBeacon, ReentrancyGuard, Mu | |||
|
|
|||
| if (remainder > 0) { | |||
| // solhint-disable-next-line avoid-low-level-calls | |||
| (bool ok, /* data */) = address(msg.sender).call{value: remainder}(""); | |||
| (bool ok, /* data */) = address(buyer).call{value: remainder}(""); | |||
There was a problem hiding this comment.
this might be undesirable since the buyer pays with WETH, but let's leave it as is and I'll get to it when I rebase on top of this. It's going to create conflicts anyway.
There was a problem hiding this comment.
would help to leave a todo though!
There was a problem hiding this comment.
If the WETH is the payment method the buyer address is LimitOrders not the signer... That's where we do the conversion from WETH to ETH and other way around...
| @@ -127,16 +130,14 @@ contract LimitOrders is ILimitOrders, MasterAwareV2, EIP712 { | |||
| emit OrderCancelled(id); | |||
| } | |||
|
|
|||
| /// @notice Handles verification of the order signature | |||
| /// @notice Returns the hash of the structured data of the order | |||
There was a problem hiding this comment.
struct is ambiguous, build is a bit misleading too, why not call the function _getOrderHash?
There was a problem hiding this comment.
I would also include the _hashTypedDataV4 function call here as well so you'd return the actual digest directly and can call the function getOrderId. The execution details hashing may be moved here as well. The _extractIdAndSigner function can then be removed as the only extra thing it does is ECDSA.recover which can be inlined. I would also make the getOrderId function public as it may be useful for testing but could be used by other contracts.
Description
Closes #1308
Add new contract that will handle verification and execution of cover limit orders
Testing
In progress
Checklist