-
Notifications
You must be signed in to change notification settings - Fork 5
Add contributing #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add contributing #12
Conversation
Summary of ChangesHello @durdana3105, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project's accessibility for new contributors by introducing a detailed "CONTRIBUTING.md" file. This document provides clear, step-by-step instructions for engaging with the LocalMind project, from initial setup to pull request submission, aiming to streamline the onboarding process, ensure consistency in contributions, and uphold code quality. Additionally, an "MIT License" has been added to formally establish the project's open-source terms. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a great initiative to improve the contributor experience by adding a CONTRIBUTING.md and LICENSE file. The contributing guide is well-structured and covers the essential workflow. My review includes several suggestions to enhance the document's clarity and correctness. Specifically, I've recommended using markdown code blocks for shell commands for better readability and adding a crucial missing step for synchronizing a forked repository. I also pointed out a minor formatting improvement for the LICENSE file.
| Before starting new work, sync your fork: | ||
|
|
||
|
|
||
| git fetch upstream | ||
| git checkout main | ||
| git merge upstream/main | ||
| git push origin main | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These instructions are missing a critical step: configuring the upstream remote. A new contributor's fork won't have an upstream remote by default, causing git fetch upstream to fail. The instructions should be updated to include adding the remote and should also place the commands in proper code blocks for clarity.
| Before starting new work, sync your fork: | |
| git fetch upstream | |
| git checkout main | |
| git merge upstream/main | |
| git push origin main | |
| Before starting new work, it's important to sync your fork with the original repository to avoid merge conflicts. | |
| **1. Configure the Upstream Remote (only needs to be done once):** | |
| Add the original repository as a remote named `upstream`. | |
| ```bash | |
| git remote add upstream https://github.com/NexGenStudioDev/LocalMind.git |
2. Sync Your Main Branch:
Before creating a new feature branch, fetch the latest changes from upstream and update your local main branch.
git fetch upstream
git checkout main
git merge upstream/main
git push origin main| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE. No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # 📌 CONTRIBUTING.md | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| git clone https://github.com/<your-username>/LocalMind.git | ||
| cd LocalMind | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and to allow users to easily copy the commands, it's best to wrap shell commands in a fenced code block with language highlighting.
| git clone https://github.com/<your-username>/LocalMind.git | |
| cd LocalMind | |
| git clone https://github.com/<your-username>/LocalMind.git | |
| cd LocalMind |
|
|
||
| git checkout -b feature-name | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| git add . | ||
| git commit -m "Short description of the change" | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Write like This
git add .
git commit -m "Short description of the change"
|
|
||
| git push origin feature-name | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| git add . | ||
| git commit -m "Short description of the change" | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Write like This
git add .
git commit -m "Short description of the change"
This pull request introduces a dedicated CONTRIBUTING.md file to help new contributors understand how to properly contribute to the LocalMind project. It outlines clear steps for forking, branching, committing, coding standards, and opening pull requests.
What’s Included:
Added CONTRIBUTING.md with:
Steps to clone and set up the project
Branching and commit guidelines
PR submission instructions
Coding standards and documentation practices
Instructions for keeping forks updated
Why This Change Is Needed:
Improves developer onboarding experience
Ensures consistency in contributions
Reduces errors and increases clarity for future contributors
Helps maintain code quality and repository organization
How It Was Done:
Created a new branch: add-contributing-file
Added a fully detailed CONTRIBUTING.md
Ensured proper markdown formatting
Committed and pushed the branch
Opening this PR for review and merge
Checklist:
CONTRIBUTING.md added
Instructions clearly written
Markdown formatting validated
Ready for review