Repository navigation
🐛 fix: drop stale named furniture from the route fixture - #12
Merged
Merged
Conversation
The route fixture's room.json still listed 12 furniture entities with named characters (table, stool, counter, pot, pan, steamer, poster-1, poster-2). The loader only accepts f1-f8, book, sprite, or a door with a portal (content/SCENE_CAPABILITIES.md), so every test that loads the fixture threw "Invalid character" and the Test workflow never passed. The fixture covers dialogue, tasks, movement and portals, and no test refers to the furniture, so remove it rather than re-author it as sprites. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
evan-ak
approved these changes
Sep 30, 2026
Contributor
|
prettier 是用来格式化 json 文件的。因为之前的 json 改动很频繁。 每次修改后单独运行 prettier 确实很麻烦 =-=。 我当时是直接绑到 pre-commit 里了。但存量的可能还没修。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
动机
The Test workflow has failed on every PR into
main, including docs-only ones, because 5 tests in 3files (
package.test.ts,movement.test.ts,immutable-content.test.ts) throwInvalid characterfrom
loadContent(prototype/content.ts:607).All three load
content/fixtures/route/. Itsscenes/room.jsonstill has 12 furniture entities withnamed characters (
table,stool,counter,pot,pan,steamer,poster-1,poster-2). Theloader and
content/SCENE_CAPABILITIES.mdonly acceptf1–f8,book,sprite, or adoorwith aportal, so loading the fixture fails before any test logic runs.
解决方案
Remove the 12
room.furniture.*entities from the fixture. The fixture exists to cover dialogue, tasksequencing, NPC movement and portal travel (see its README), and no test or story refers to the
furniture, so I didn't re-author it as
spriteentities. The file only loses lines. Nothing elsechanges.
npm testnow passes locally: 23 suites, 50 tests.类型
🤖 Generated with Claude Code