add warped BN256G2 contract #1
Conversation
cicr99
left a comment
cicr99
left a comment
There was a problem hiding this comment.
Could you also add the modified Solidity contract?
|
@cicr99 I've just updated the PR. I realized that we could implement modular inversion in cairo instead of expmod in a very simple way. Since modInv is actually expmod(a,n-2,n). I've proposed this function to be included in cairo-libs: |
| @@ -0,0 +1,18 @@ | |||
| # Transpiled [BN256G2.sol](https://github.com/musalbas/solidity-BN256G2) library. | |||
There was a problem hiding this comment.
Could you add the warp version you used, as well as the Cairo version? Also, could it be possible to have the solidity performance info when used the same input on the solidity contract (like gas use and execution time, I believe it may be helpful for future re-transpilations with cairo 1).
|
|
||
| A few changes needed to be made to the contract in order for warp to transpile it correctly. | ||
| - The keyword "library" needed to be changed to "contract" | ||
| - Solidity version needed to be updated to 0.8.0 |
There was a problem hiding this comment.
I would specify 0.8.14 which is the solc version used by warp
| This contract doesn't work properly on starknet because expmod is too heavy for the current implementation of the sequencer in starknet. One expmod with 256 bit as exponent takes 500k steps. | ||
| That's why it is imposible to test this. |
There was a problem hiding this comment.
Could you expand on this a little bit more. Like how much of this heavy computation is Warps fault or the current sequencer.
3 participants
Original contract:
https://github.com/musalbas/solidity-BN256G2