Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change latest flag behavior #483

Merged
merged 6 commits into from
Jan 24, 2025
+68 −16
Merged

Change latest flag behavior #483

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9be726d
feat: override latest tag if image is set
stdevMac Nov 29, 2024
aa766fb
docs: update changelog
stdevMac Nov 29, 2024
3ebaf4a
fix: latest on nimbus
stdevMac Dec 1, 2024
a422036
Merge branch 'develop' into fix/override_latest
stdevMac Dec 4, 2024
9f5d527
fix: op-execution modified on latest
stdevMac Dec 6, 2024
23b40c0
Merge branch 'develop' into fix/override_latest
stdevMac Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: op-execution modified on latest
@stdevMac
stdevMac committed Dec 6, 2024
commit 9f5d527097354348d8a9855a58e4a4040678292c
2 changes: 1 addition & 1 deletion cli/generate.go
View file
Original file line number Diff line number Diff line change
@@ -485,7 +485,7 @@ func valClients(allClients clients.OrderedClients, flags *GenCmdFlags, services
executionOpClient.Name = strings.ReplaceAll(optimismExecutionParts[0], "-", "")
if len(optimismExecutionParts) > 1 {
executionOpClient.Image = strings.Join(optimismExecutionParts[1:], ":")
executionClient.Modified = true
executionOpClient.Modified = true
}
}
executionOpClient.SetImageOrDefault(strings.Join(optimismExecutionParts[1:], ":"))