Move prewarming as early as possible #8001
Conversation
|
Is it worth it though? How much do we gain on normal flow? |
Means it gets the prewarmer threads queued to ThreadPool before Every microsecond counts for the early prewarms (beacon root and first txs) |
|
ok does it register on our grafana graphs? |
Yes though can't find it atm (am doing a full sync) We want the prewarming to front run the txs. Block takes 10ms running 300 tx, so roughly 33 microseconds per tx. At that speed any and all edge is significant; as to whether the tx is prewarmed or not. This I think is the maximum it can go ahead (I moved it earlier but was unhappy that some of the block wasn't set in state, so missing trienode errors) |
|
Moved |
| skipPrewarming = preWarmer is null || suggestedBlock.Transactions.Length < 3; | ||
| // If cancelationTokenSource is not null it means we are in first iteration of loop | ||
| // and started prewarming at method entry, so don't start it again | ||
| if (cancellationTokenSource is null && !skipPrewarming) | ||
| { | ||
| (cancellationTokenSource, preWarmTask) = PreWarmTransactions(suggestedBlock, preBlockStateRoot); | ||
| } |
There was a problem hiding this comment.
This code is very similar to the one above, can we have a helper method?
There was a problem hiding this comment.
Moved into PreWarm method
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing