Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ITrieStore
andIWorldState
outside ofINethermindApi
. These should not be used directly as it will make swapping state layout very hard.ISnapServer
fromNethermind.Synchronization
toNethermind.State
, exposing them fromIWorldStateManager
. These usesITrieStore
so, to hideITrieStore
, it need to be inIWorldStateManager
. Also, paprika probably need to have a completely different snap server implementation.PruningTrieStateFactory
. This should make it easier to be used in tests and make it clear, which part of the initialization is for the pruning trie store and hopefully prevent future exposure of trie store specific interface.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing