Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/isolate worldstate #7976

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Dec 28, 2024

  • Move ITrieStore and IWorldState outside of INethermindApi. These should not be used directly as it will make swapping state layout very hard.
  • Move healing related code and ISnapServer from Nethermind.Synchronization to Nethermind.State, exposing them from IWorldStateManager. These uses ITrieStore so, to hide ITrieStore, it need to be in IWorldStateManager. Also, paprika probably need to have a completely different snap server implementation.
  • Move all pruning trie store state related initialization code into PruningTrieStateFactory. This should make it easier to be used in tests and make it clear, which part of the initialization is for the pruning trie store and hopefully prevent future exposure of trie store specific interface.

Types of changes

What types of changes does your code introduce?

  • Refactoring

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Testing....

Copy link
Contributor

@Scooletz Scooletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No input from my end. INodeStorage is still in the api, which in my understanding should be a subject of a further refactor when another storage (like Paprika) is used. Appreciate the removal of the TrieStore though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants