-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cyprian my branch #169
base: main
Are you sure you want to change the base?
Cyprian my branch #169
Conversation
cypriansakwa
commented
Dec 28, 2024
- Added detailed project overview, applications and features of LatticeFold.
- Included build troubleshooting tips.
- Enhanced Prerequisites and Instructions
- Under Frontends, showed the essence of R1CS and CCS, highlighting their roles in representing arithmetic circuits and providing flexible circuit definitions, respectively.
- Highlighted how to Run an example using Cargo.
- Improved formatting and added a Table of Contents.
1. Added detailed project overview, applications and features of LatticeFold. 2. Included build troubleshooting tips. 3. Enhanced Prerequisites and Instructions 4. Under Frontends, showed the essence of R1CS and CCS, highlighting their roles in representing arithmetic circuits and providing flexible circuit definitions, respectively. 5. Highlighted how to Run an example using Cargo 6. Improved formatting and added a Table of Contents.
1. Added detailed project overview, applications and features of LatticeFold. 2. Included build troubleshooting tips. 3. Enhanced Prerequisites and Instructions 4. Under Frontends, showed the essence of R1CS and CCS, highlighting their roles in representing arithmetic circuits and providing flexible circuit definitions, respectively. 5. Highlighted how to Run an example using Cargo. 6. Improved formatting and added a Table of Contents.
I am Cyprian Sakwa a PhD intern at Nethermind currently working on cryptography research. @NethermindEth, please review this pull request. |
Hi. How are you today? I request for your review here. @ElijahVlasov , @cypriansakwa , @matthew-a-klein , @ivolkg , @v0-e , @tkstanczak , @tkstanczak , @frozenspider . Thanks. |
Hi @ivolkg , @matthew-a-klein , @ElijahVlasov , @v0-e , @cupicmarko , @Fantoni0 , @miha-stopar , @maksimryndin , @tkstanczak . I hope this message finds you well. This is a gentle reminder regarding a pull request I submitted, which is currently awaiting review: https://github.com/NethermindEth/latticefold/pulls . I would greatly appreciate your feedback or any comments you may have. If there are any issues or concerns with the pull request, please feel free to let me know here, and I will be happy to address them promptly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments.
Implemented all the suggested changes to enhance clarity and readability. Additionally, we have removed repetitions and redundancies to improve the overall quality of the document. We believe these revisions have significantly strengthened the document. Please let us know if there are any additional adjustments or refinements needed.
Dear @ElijahVlasov , I hope this message finds you well. I am writing to inform you that I have implemented the changes you requested during your review. The modifications have been incorporated in line with your feedback, and I believe they address the concerns raised. I kindly ask you to review the updated work at your earliest convenience and provide any additional advice or suggestions. Your guidance is invaluable, and I look forward to your insights. Thank you for your time and support. Best regards Cyprian Sakwa, Nethermind's intern |
…nd detailed documentation Deleted Table of contents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subject: Follow-Up on Pull Request Review
Hi @ElijahVlasov
I hope you're doing well.
I made the requested changes to my pull request based on your feedback. When you have a moment, could you please take another look and let me know if anything else needs adjustment?
I appreciate your time and guidance. Looking forward to your thoughts!
Best,
Cyprian Sakwa