Include slf4j "simple" binding/provider as a runtime dependency#371
Closed
thomasheritage wants to merge 1 commit intoNetflix:masterfrom
Closed
Include slf4j "simple" binding/provider as a runtime dependency#371thomasheritage wants to merge 1 commit intoNetflix:masterfrom
thomasheritage wants to merge 1 commit intoNetflix:masterfrom
Conversation
Contributor
Author
|
Related to #349 |
Contributor
|
Thanks - this has been addressed via #375 slf4j is also needed for compilation in test, so this has been declared as |
Contributor
Author
|
Thanks @fschleich for resolving this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A logging provider needs to be specified when running the Photon applications from the commandline (e.g.
com.netflix.imflibrary.app.IMPAnalyzer) -- otherwise there is an error per #366However, is this inappropriate for other ways of running Photon? (e.g. as a library)
If so, perhaps this dependency could be moved to a new Gradle "dependency configuration" that can be selected specifically when running Photon applications from the commandline?
Closes #366