Conversation
The comment above CLIENT_CACHE_MAX_SIZE said the value is in bytes, but the only consumer (FileCache._garbage_collect) multiplies it by 1024**2, so the value is interpreted in megabytes. The default of 10000 is therefore ~10 GB, consistent with the MB interpretation. Reading the value as bytes leads operators to oversize the cap by a factor of ~1,048,576 (for example, setting 100000000 intending ~100 MB actually configures a ~100 TB cap), which effectively disables client cache garbage collection. Correct the comment to state MB; no behavior changes. Signed-off-by: Anas Khan <83116240+anxkhn@users.noreply.github.com>
Contributor
Greptile SummaryThis PR corrects the unit label for the client cache size setting.
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "docs: correct CLIENT_CACHE_MAX_SIZE unit..." | Re-trigger Greptile |
Author
|
@saikonen when you have a chance, could you please take a look at this pr and let me know if any update is needed? |
Shriprasad-P
left a comment
Shriprasad-P
left a comment
There was a problem hiding this comment.
Review
PR: docs: correct CLIENT_CACHE_MAX_SIZE unit comment to MB
Touched: metaflow/metaflow_config.py
- Small docs/comment cleanup; low risk if wording is accurate.
- Size looks manageable (+1/-1).
Commenting as a drive-by reviewer after reading the diff. Happy to look again if maintainers want a deeper pass on a specific file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
The inline comment above
CLIENT_CACHE_MAX_SIZEsays the value is "in bytes", butthe only consumer multiplies it by
1024**2, so the value is actually interpretedin megabytes. This corrects the comment to "in MB". No behavior changes.
Issue
Fixes #<OPEN_ACKNOWLEDGED_ISSUE> <!-- REQUIRED: do not open the PR until this