Merge pull request #3646 from havron/filter-autorotate

Add rotation toggle and filtering to table view

CHANGELOG.rst

@@ -1,6 +1,51 @@
 Changelog
 =========
 
+0.10.0 - `2021-06-28`
+~~~~~~~~~~~~~~~~~~~~~
+
+This release introduces a breaking change (PR `#3646 <https://github.com/Netflix/lemur/pull/3646>`_) to the following API endpoint: 
+
+- `POST /certificates/1/update/notify <https://lemur.readthedocs.io/en/latest/developer/index.html#lemur.certificates.views.Certificates.post>`_
+
+The endpoint is now:
+
+- `POST /certificates/1/update/switches <https://lemur.readthedocs.io/en/latest/developer/index.html#lemur.certificates.views.Certificates.post>`_
+
+The new endpoint honors the existing `notify` request parameter, and additionally accepts a new `rotation` parameter. 
+As a result of this change, the certificate table view now includes rotation switches and filtering by rotation status.
+
+
+Other notable changes in this release:
+
+- ACME:
+    - New celery task to prevent duplicate certificates from being autorotated
+    - ACME DNS-01 Challenges are supported in synchronous mode
+    - DNS provider check fails gracefully if not found
+- Authentication:
+    - SSO auth now returns a newly created user during initial login
+    - CSRF protection is added to OAuth2.0
+- Notifications:
+    - New reissue failed notification
+    - New reissue with no endpoints notification
+    - New revocation notification
+- Plugins:
+    - Plugin option values are validated server-side
+    - Some plugin option validations updated to compile successfully server-side
+- Database:
+  - Source and Destination deletions remove certificate associations with new confirmation dialog
+- Dependency updates and conflict resolutions
+- Expanded audit logs
+
+And several smaller bugfixes and improvements.
+
+Special thanks to all who contributed to this release, notably:
+
+- `havron <https://github.com/havron>`_
+- `tho <https://github.com/tho>`_
+- `mizzy <https://github.com/mizzy>`_
+
+
 0.9.0 - `2021-03-17`
 ~~~~~~~~~~~~~~~~~~~~
 

lemur/certificates/schemas.py

@@ -365,6 +365,7 @@ class CertificateShortOutputSchema(LemurOutputSchema):
     name = fields.String()
     owner = fields.Email()
     notify = fields.Boolean()
+    rotation = fields.Boolean()
     authority = fields.Nested(AuthorityNestedOutputSchema)
     issuer = fields.String()
     cn = fields.String()

lemur/certificates/service.py

@@ -354,14 +354,18 @@ def cleanup_owner_roles_notification(owner_name, kwargs):
     kwargs["notifications"] = [n for n in kwargs["notifications"] if not n.label.startswith(notification_prefix)]
 
 
-def update_notify(cert, notify_flag):
+def update_switches(cert, notify_flag=None, rotation_flag=None):
     """
-    Toggle notification value which is a boolean
+    Toggle notification and/or rotation values which are boolean
     :param notify_flag: new notify value
+    :param rotation_flag: new rotation value
     :param cert: Certificate object to be updated
     :return:
     """
-    cert.notify = notify_flag
+    if notify_flag is not None:  # check for None allows value of False to continue
+        cert.notify = notify_flag
+    if rotation_flag is not None:
+        cert.rotation = rotation_flag
     return database.update(cert)
 
 
@@ -561,6 +565,8 @@ def render(args):
             )
         elif "notify" in filt:
             query = query.filter(Certificate.notify == truthiness(terms[1]))
+        elif "rotation" in filt:
+            query = query.filter(Certificate.rotation == truthiness(terms[1]))
         elif "active" in filt:
             query = query.filter(Certificate.active == truthiness(terms[1]))
         elif "cn" in terms:

lemur/certificates/views.py

@@ -352,6 +352,7 @@ def get(self):
         parser.add_argument("owner", type=inputs.boolean, location="args")
         parser.add_argument("id", type=str, location="args")
         parser.add_argument("active", type=inputs.boolean, location="args")
+        parser.add_argument("rotation", type=inputs.boolean, location="args")
         parser.add_argument(
             "destinationId", type=int, dest="destination_id", location="args"
         )
@@ -931,21 +932,22 @@ def put(self, certificate_id, data=None):
     @validate_schema(certificate_edit_input_schema, certificate_output_schema)
     def post(self, certificate_id, data=None):
         """
-        .. http:post:: /certificates/1/update/notify
+        .. http:post:: /certificates/1/update/switches
 
-           Update certificate notification
+           Update certificate boolean switches for notification or rotation
 
            **Example request**:
 
            .. sourcecode:: http
 
-              POST /certificates/1/update/notify HTTP/1.1
+              POST /certificates/1/update/switches HTTP/1.1
               Host: example.com
               Accept: application/json, text/javascript
               Content-Type: application/json;charset=UTF-8
 
               {
-                 "notify": false
+                 "notify": false,
+                 "rotation": false
               }
 
            **Example response**:
@@ -980,6 +982,7 @@ def post(self, certificate_id, data=None):
                 "description": null,
                 "deleted": null,
                 "notify": false,
+                "rotation": false,
                 "notifications": [{
                     "id": 1
                 }]
@@ -1029,7 +1032,7 @@ def post(self, certificate_id, data=None):
                     403,
                 )
 
-        cert = service.update_notify(cert, data.get("notify"))
+        cert = service.update_switches(cert, notify_flag=data.get("notify"), rotation_flag=data.get("rotation"))
         log_service.create(g.current_user, "update_cert", certificate=cert)
         return cert
 
@@ -1516,7 +1519,7 @@ def put(self, certificate_id, data=None):
     Certificates, "/certificates/<int:certificate_id>", endpoint="certificate"
 )
 api.add_resource(
-    Certificates, "/certificates/<int:certificate_id>/update/notify", endpoint="certificateUpdateNotify"
+    Certificates, "/certificates/<int:certificate_id>/update/switches", endpoint="certificateUpdateSwitches"
 )
 api.add_resource(CertificatesStats, "/certificates/stats", endpoint="certificateStats")
 api.add_resource(

lemur/static/app/angular/certificates/services.js

@@ -305,7 +305,7 @@ angular.module('lemur')
       return certificate.customGET('key');
     };
 
-    CertificateService.updateNotify = function (certificate) {
+    CertificateService.updateSwitches = function (certificate) {
       return certificate.post();
     };
 

lemur/static/app/angular/certificates/view/view.js

@@ -115,7 +115,7 @@ angular.module('lemur')
     };
 
     $scope.updateNotify = function (certificate) {
-      CertificateService.updateNotify(certificate).then(
+      CertificateService.updateSwitches(certificate).then(
         function () {
           toaster.pop({
             type: 'success',
@@ -133,6 +133,25 @@ angular.module('lemur')
           certificate.notify = false;
         });
     };
+    $scope.updateRotation = function (certificate) {
+      CertificateService.updateSwitches(certificate).then(
+        function () {
+          toaster.pop({
+            type: 'success',
+            title: certificate.name,
+            body: 'Updated!'
+          });
+        },
+        function (response) {
+          toaster.pop({
+            type: 'error',
+            title: certificate.name,
+            body: 'Unable to update! ' + response.data.message,
+            timeout: 100000
+          });
+          certificate.rotation = false;
+        });
+    };
     $scope.getCertificateStatus = function () {
       var def = $q.defer();
       def.resolve([{'title': 'True', 'id': true}, {'title': 'False', 'id': false}]);

lemur/static/app/angular/certificates/view/view.tpl.html

@@ -37,6 +37,12 @@ <h2 class="featurette-heading">Certificates
                 <li>{{ certificate.name }}</li>
                 <li><span class="text-muted">{{ certificate.owner }}</span></li>
               </ul>
+            </td>
+             <td data-title="'Autorotate'" filter="{ 'rotation': 'select' }" filter-data="getCertificateStatus()">
+              <form>
+                <switch ng-change="updateRotation(certificate)" id="rotation" name="rotation"
+                  ng-model="certificate.rotation" class="green small"></switch>
+              </form>
             </td>
             <td data-title="'Notify'" filter="{ 'notify': 'select' }" filter-data="getCertificateStatus()">
               <form>