Introduce Dynamo model #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolynch
reviewed
Sep 29, 2023
| AccessConsistency.best_effort, | ||
| AccessConsistency.eventual, | ||
| AccessConsistency.read_your_writes, | ||
| AccessConsistency.never, |
There was a problem hiding this comment.
I believe DDB can do up to serializable (essentially all consistency levels) in the same region
There was a problem hiding this comment.
You could probably determine the default strong/weak via this as well (if someone asks for eventual, you don't need to bill for strong reads)
jolynch
reviewed
Sep 29, 2023
raj14243
commented
Oct 6, 2023
| @@ -325,6 +325,92 @@ def models(self) -> Dict[str, CapacityModel]: | |||
| def hardware_shapes(self) -> HardwareShapes: | |||
| return self._shapes | |||
|
|
|||
| def _plan_percentiles( | |||
There was a problem hiding this comment.
Introduced this method to address the following issue.
Previously the steps to generate percentile plan was
- generate percentile desires
- plan_certain using the generated desires
Issue in the above is, when percentile desires are generated the attributes that are not supplied by user are replaced with defaults declared in CapacityDesires interface. This results inparent_desires.merge_withnot merging the defaults i.e. not merging the model defaults for attributes that are not supplied by user.
To mitigate the above issue, we first generate desires by merging with model defaults and then generate the percentile desires using the merged desires.
raj14243
force-pushed
the
feature/rummadisetty/ddb-model
branch
from
3f2041e to
4fb594f
Compare
raj14243
force-pushed
the
feature/rummadisetty/ddb-model
branch
from
4fb594f to
0f4e682
Compare
jolynch
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.