Skip to content

feat: bump CI to Rust 1.83 #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

feat: bump CI to Rust 1.83 #153

wants to merge 2 commits into from

Conversation

r-near
Copy link
Contributor

@r-near r-near commented Feb 24, 2025

No description provided.

@r-near r-near enabled auto-merge (squash) February 24, 2025 21:37
@r-near r-near requested a review from karim-en February 24, 2025 21:37
@karim-en
Copy link
Collaborator

@r-near to fix the CI I think we need to use the cargo_near_build here

let toolchain = read_toolchain(project_path).await?;
like we did it here https://github.com/Near-One/omni-bridge/blob/f1ad7015414e6cff49d7ba793c13742eb02ff380/near/omni-tests/src/helpers.rs#L20

@r-near
Copy link
Contributor Author

r-near commented Feb 24, 2025

@r-near to fix the CI I think we need to use the cargo_near_build here

let toolchain = read_toolchain(project_path).await?;

like we did it here Near-One/omni-bridge@f1ad701/near/omni-tests/src/helpers.rs#L20

The current issue with this PR run is that near-sandbox is not able to deserialize the contract: CompilationError(PrepareError(Deserialization)) - this is because the near sandbox version is too outdated.

Looking at the code, it seems the existing code does indeed reference the correct Rust toolchain (1.83.0 in this case) to build the .wasm binary - the problem is the sandbox binary is too old to support 1.83.0-built contracts (I think).

There's some discussion here about how this error comes up:

The reason it works on my local machine is because my personal toolchain is 1.83.0 (so it can bypass the home dependency issue, since it's a dev dependency) - but the contracts are built with 1.80.0. I suppose we could do something similar here by simply writing channel = 1.83.0 into the root rust-toolchain file. I tested it and it works locally - however there's a section in the README explicitly saying we shouldn't do that 🤷‍♂️

@r-near
Copy link
Contributor Author

r-near commented Feb 25, 2025

Closing in favor of #155

@r-near r-near closed this Feb 25, 2025
auto-merge was automatically disabled February 25, 2025 03:25

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants