Remove MCP crates

[Nayshins]

No description provided.

[mentatbot]

I'm getting to work. See my steps and track my cost here.

• Wake on any new activity.
  _{I always see new activity while actively working. When paused, I'll only respond when tagged unless this box is checked.}

[mentatbot]

Pull Request Review: Remove MCP crates

I've reviewed the changes to remove MCP (Model Context Protocol) related dependencies from the project. Here are my observations:

Changes Overview

• Removed optional HTTP server dependencies: axum, tower, tower-http
• Removed other dependencies likely used for the MCP server: async-trait, thiserror, futures
• Removed the http feature that referenced these dependencies
• Reorganized some remaining dependencies

Questions and Considerations

1. Is this removal temporary (as suggested by the branch name "remove-mcp-for-now") or permanent?
2. Will users who relied on the MCP server functionality (ummon serve command) be affected?
3. Have other related code changes been made to:
   • Remove the serve command from the CLI
   • Update any code that referenced the removed dependencies
   • Update documentation that mentions MCP functionality

Documentation Impact

The README currently contains significant sections about MCP server functionality, including:

• Description of MCP as a core feature
• Instructions for using ummon serve
• Example MCP usage with MCP Inspector
• Testing the MCP server

If this is a permanent removal, these sections would need to be updated or removed to avoid confusion for users.

Suggestion

Consider adding a note to the PR description explaining the rationale for removing the MCP crates and whether this is temporary or permanent, which would help reviewers understand the context of this change.

[mentatbot]

Additional Observations

After examining the CLI code (src/cli.rs) and commands module (src/commands/mod.rs), I've noticed some inconsistencies between the codebase and documentation:

1. The CLI doesn't currently include a serve command for the MCP server functionality that's described in the README.
2. There's no module for MCP server implementation in the commands directory (no serve.rs).

This suggests one of two possibilities:

• The MCP server command was previously removed from the code but remained in the dependencies and documentation
• The MCP server functionality was planned and documented but not fully implemented in the CLI

Either way, this PR appears to be removing the dependencies for a feature that isn't visible in the current CLI implementation. If this is intentional, it might be worth considering a follow-up PR to update the README to remove or modify the MCP server sections to avoid confusion for users.

Given the branch name "remove-mcp-for-now", it seems this might be a temporary removal. If MCP functionality is planned to return in the future, adding a note about this to the README would be helpful for users and contributors.

[mentatbot]

Final Review Summary

After further inspection, I've found:

1. The CI build passed successfully ✅, suggesting the removed dependencies aren't used in the actual implementation.

2. There's a reference to "MCP Integration" documentation in docs/query_system.md that links to a non-existent file: docs/mcp_integration.md.

3. The README extensively documents MCP functionality and the ummon serve command, but:

   • There's no serve command in the CLI implementation
   • No MCP server module exists in the commands directory

This suggests the MCP functionality was documented and dependencies were added in preparation, but the implementation might not have been fully completed before this PR to remove the MCP-related dependencies.

Recommendations:

1. Update Documentation: The README should be updated to either:

   • Remove references to MCP functionality and the serve command
   • Add a note that MCP functionality is planned for a future release (if that's the case)

2. Fix Documentation References: Update or remove the reference to mcp_integration.md in the query system documentation.

3. Add PR Context: Consider adding a brief explanation to the PR description about why MCP is being removed "for now" and any plans for its future.

The code changes themselves look good - removing unused dependencies will simplify the project and reduce build times. The main issue is ensuring documentation accurately reflects the codebase's actual capabilities.

[Nayshins]

@MentatBot can you add the changes in your Recommendations?

[mentatbot]

Changes Made

I've updated the documentation to remove references to the MCP (Model Context Protocol) functionality as requested:

In README.md:

1. Removed the "AI Agent Integration with MCP" from the Core Features section
2. Removed the ummon serve command example from the Usage section
3. Removed the entire MCP Server section and its subsections (Available Tools, Example MCP Usage)
4. Removed "MCP server for AI agent integration" from the Architecture description
5. Removed the "Testing the MCP Server" section
6. Updated the description of the JavaScript test files, removing specific references to MCP clients

In docs/query_system.md:

1. Removed the reference to the non-existent "MCP Integration" documentation file

These changes align the documentation with the code changes in this PR, which removes the MCP-related dependencies. The documentation now accurately reflects the current functionality without referring to features that aren't currently implemented.