Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MCP code and associated functions #44

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Conversation

Nayshins
Copy link
Owner

This was getting ahead of itself, and now going to wait for an officially supported rust mcp crate

This was getting ahead of itself, and now going to wait for an
officially supported rust mcp crate
Copy link
Contributor

mentatbot bot commented Mar 18, 2025

I'm getting to work. See my steps and track my cost here.

  • Wake on any new activity.
    I always see new activity while actively working. When paused, I'll only respond when tagged unless this box is checked.

Copy link
Contributor

@mentatbot mentatbot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review - Removal of MCP Code

I've reviewed the PR which removes the Model Context Protocol (MCP) code and associated functions from the codebase. This appears to be a clean and thorough removal of a feature that was added prematurely, as noted in the PR description.

Changes Assessment

  • ✅ Complete removal of all MCP-related functionality
  • ✅ Removed the Serve CLI command
  • ✅ Deleted all MCP-specific modules and files
  • ✅ Removed MCP-related functionality from the knowledge graph implementation
  • ✅ Updated tests to match the new (reduced) functionality

Observations

  • Some of the removed functionality in knowledge_graph.rs could potentially be useful independent of MCP (like search capabilities and relationship exploration). If these are needed later, they can be re-added in a more focused way.
  • There are some whitespace-only changes in files like benches/parsing_benchmarks.rs, but these appear to be harmless formatting adjustments.

The changes look good to me. Waiting for CI to complete, but the changes are well-structured and focused on the single concern of removing MCP code.

@Nayshins Nayshins merged commit df81304 into master Mar 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant