Basic Build Command cleanup #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the handling of the CA certificate in the
Native\Electronpackage. The most important changes involve the introduction of a new trait for copying the CA certificate and the removal of redundant code related to certificate handling.Introduction of
CopiesCertificateAuthoritytrait:src/Traits/CopiesCertificateAuthority.php: Added a new traitCopiesCertificateAuthorityto encapsulate the logic for copying the CA certificate.Refactoring to use the new trait:
src/Commands/BuildCommand.php: Updated theBuildCommandclass to use the newCopiesCertificateAuthoritytrait and removed the old certificate copying logic. [1] [2] [3]src/Commands/DevelopCommand.php: Updated theDevelopCommandclass to use the newCopiesCertificateAuthoritytrait and added the certificate copying call. [1] [2] [3]Removal of redundant environment variables:
src/Commands/BuildCommand.php: Removed theNATIVEPHP_CERTIFICATE_FILE_PATHenvironment variable.src/Traits/ExecuteCommand.php: Removed theNATIVEPHP_CERTIFICATE_FILE_PATHenvironment variable from theexecuteCommandmethod.Test for the new trait:
tests/Unit/Traits/CopiesCertificateAuthorityTest.php: Added a unit test to verify the functionality of theCopiesCertificateAuthoritytrait.Code cleanup:
resources/js/php.js: Removed the code related to copying the certificate file. [1] [2]