Skip to content

decompiler: fix INT_LEFT for constant bitshift by 0 and varnodes > 8 #8706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fkil wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −0
Open

decompiler: fix INT_LEFT for constant bitshift by 0 and varnodes > 8 #8706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Ghidra/Features/Decompiler/src/decompile/cpp/coreaction.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3698,6 +3698,8 @@ void ActionDeadCode::propagateConsumed(vector<Varnode *> &worklist)
if (sz > sizeof(uintb)) { // If there exists bits beyond the precision of the consume field
if (sa >= 8*sizeof(uintb))
a = ~((uintb)0); // Make sure we assume one bits where we shift in unrepresented bits
else if (!sa) // Special case to avoid undefined behavior caused by shifting too many bits
a = outc;
else
a = (outc >> sa) ^ ( (~((uintb)0)) << (8*sizeof(uintb)-sa));
sz = 8*sz -sa;
Expand Down