[FINNA-3012] Renormalize displaying videos #3155
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Actually managed to break this somehow after yesterday... Fixing... Edit: fixed |
… has been marked as legacy and found in custom theme
…sted player height
|
@LuomaJuha Voitko mergetä uusimman dev:n? |
Author
|
@EreMaijala dodi, nyt pitäis olla |
EreMaijala
requested changes
Oct 6, 2025
| // Template for using proper styles, when appending video viewer inside an element. | ||
| %iframe-centering-template { | ||
| height: $inline-video-player-desktop-height; | ||
| @media (max-width: $screen-md-max) { |
| @@ -0,0 +1,57 @@ | |||
| <?php | |||
| /** | |||
| * Component for opening or displaying proper video content. | |||
There was a problem hiding this comment.
Suggested change
| * Component for opening or displaying proper video content. | |
| * Component for opening or displaying video content. |
| * @param string description Text description inside the button. Default is format_Video translated. | ||
| */ | ||
|
|
||
| $inlineVideoPlayer = $this->inline ?? false; |
There was a problem hiding this comment.
Missä dokumentaatio inline-parametrille?
| ]; | ||
|
|
||
| if ($index === 0 && $inlineVideoPlayer) { | ||
| $buttonAttributes['class'] .= ' active-video'; |
There was a problem hiding this comment.
Aloittaako tämä toiston automaattisesti? Jos aloittaa, niin miksi? Jos ei, niin mikä tämän merkitys on?
| ?> | ||
| <button <?=$this->htmlAttributes($buttonAttributes);?> <?php if ($videoSources): ?>data-video-sources="<?=htmlspecialchars(json_encode($videoSources), ENT_QUOTES, 'UTF-8');?>"<?php endif;?>> | ||
| <?=$this->icon('video-play', 'video-play-icon');?> | ||
| <span class="video-desc"><?=$this->escapeHtml($this->truncate(ucfirst($description), 30))?></span> |
There was a problem hiding this comment.
Kuuluuko ucfirst tänne? Vai olisiko se ennemmin kutsujan tai driverin tms. asia?
Co-authored-by: Ere Maijala <[email protected]>
Co-authored-by: Ere Maijala <[email protected]>
Co-authored-by: Ere Maijala <[email protected]>
Co-authored-by: Ere Maijala <[email protected]>
Co-authored-by: Ere Maijala <[email protected]>
…irst out from button
Co-authored-by: Ere Maijala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes 2 custom elements, adds a component like others
Removes displaying of videos inside popups, instead opens them in their respective windows
Fixes displaying if inline video is set to true
Use Lightbox instead of finna-popup
Checked that templates record-video-player and record-online-urls were modified in kavis templates. They have a locally managed player code.
#3307 Requires