Fix issue #370 (energy_from_power returns incorrect index for shifted hourly data)#437
Merged
mdeceglie merged 15 commits intodevelopmentfrom Dec 30, 2024
Merged
Fix issue #370 (energy_from_power returns incorrect index for shifted hourly data)#437mdeceglie merged 15 commits intodevelopmentfrom
mdeceglie merged 15 commits intodevelopmentfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #437 +/- ##
===============================================
+ Coverage 95.91% 96.08% +0.17%
===============================================
Files 11 11
Lines 2250 2250
===============================================
+ Hits 2158 2162 +4
+ Misses 92 88 -4 ☔ View full report in Codecov by Sentry. |
mdeceglie
requested changes
Dec 17, 2024
Collaborator
mdeceglie
left a comment
mdeceglie
left a comment
There was a problem hiding this comment.
The solution looks good. I suggest we add a test, can just use the example from the issue.
| * Deploy workflow was replaced with trusted publisher workflow for pypi (:pull:`427`) | ||
| * Fix pandas 2.0.0 deprications and update syntax changes (:pull:`428`) | ||
| * Fix numpy 2.0.0 deprications and update syntax changes (:pull:`428`) | ||
| * Fix `energy_from_power`` returns incorrect index for shifted hourly data (:issue:`370`, :pull:`437`) |
Collaborator
There was a problem hiding this comment.
Let's move this to a pending changelog section
Collaborator
Author
Done. |
mdeceglie
reviewed
Dec 30, 2024
Collaborator
mdeceglie
left a comment
mdeceglie
left a comment
There was a problem hiding this comment.
Minor fix suggested in the tests, then this should be good to go.
mdeceglie
approved these changes
Dec 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__init__.py