Skip to content

Fix Reordered Tables#122

Merged
mitchute merged 4 commits into
mainfrom
fix-reordered-tables
Apr 16, 2026
Merged

Fix Reordered Tables#122
mitchute merged 4 commits into
mainfrom
fix-reordered-tables

Conversation

@mitchute

Copy link
Copy Markdown
Collaborator

PR address the following:

  • Tables with reordered rows were being treated as diffs, and failing.
  • String values inside tables were being compared in a case-insensitive way, and not being caught.

@coveralls

coveralls commented Apr 16, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 24513970937

Warning

No base build found for commit c7ff180 on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 100.0%

Details

  • Patch coverage: 146 of 146 lines across 2 files are fully covered (100%).

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 4697
Covered Lines: 4697
Line Coverage: 100.0%
Coverage Strength: 2.99 hits per line

💛 - Coveralls

@Myoldmopar Myoldmopar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having 100% test coverage is key here. The code should definitely continue to be refactored as done here, and having the testing in place is critical. This is a good improvement, carry on.

@mitchute

Copy link
Copy Markdown
Collaborator Author

Thanks for looking it over @Myoldmopar. Merging.

@mitchute mitchute merged commit 2336edd into main Apr 16, 2026
4 checks passed
@mitchute mitchute deleted the fix-reordered-tables branch April 16, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants