Skip to content

Fix cppcheck errors: final follow-up #11584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dareumnam wants to merge 17 commits into
base: develop
Choose a base branch
from
Draft

Fix cppcheck errors: final follow-up #11584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
2b6e7b0
Suppress the duplicateExpression cppcheck error as the line has been …
dareumnam May 7, 2026
1b6e669
Merge branch 'develop' of https://github.com/NatLabRockies/EnergyPlus…
dareumnam May 7, 2026
a5a0485
fix remaning unreadVariable
dareumnam May 7, 2026
9a2af19
remaining variableScope
dareumnam May 8, 2026
f86defa
remaining shadowVariable
dareumnam May 8, 2026
bb24caf
remaining duplicateCondition
dareumnam May 8, 2026
f062ca0
remaining constParameterPointer
dareumnam May 8, 2026
bb49211
remaining uselessAssignmentArg
dareumnam May 8, 2026
5f4fe7b
remaining constVariablePointer
dareumnam May 8, 2026
b06afe3
remaining constVariable
dareumnam May 8, 2026
492a893
fix uselessCallsSubstr
dareumnam May 14, 2026
72c2979
Merge branch 'develop' of https://github.com/NatLabRockies/EnergyPlus…
dareumnam May 14, 2026
122a56c
fix knownConditionTrueFalse
dareumnam May 14, 2026
7b4b020
fix unassignedVariable
dareumnam May 14, 2026
a7cdb4e
fix passedByValueCallback
dareumnam May 14, 2026
162db20
fix stlIfStrFind
dareumnam May 14, 2026
59229e4
fix constVariableReference 1
dareumnam May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/ConvertInputFormat/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,6 @@ Select one (case insensitive):
#else
if (number_of_threads > 1) {
displayMessage("ConvertInputFormat is not compiled with OpenMP. Only running on 1 thread, not requested {} threads.", number_of_threads);
number_of_threads = 1;
Copy link
Copy Markdown
Collaborator Author

@dareumnam dareumnam May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the non-OpenMP path, number_of_threads = 1 is assigned inside the if block but never read afterward. Removed the dead assignment.

}

for (auto const &file : files) {
Expand Down
10 changes: 5 additions & 5 deletions src/EnergyPlus/AirflowNetwork/src/Solver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5041,12 +5041,12 @@ namespace AirflowNetwork {
if (simulation_control.DuctLoss) {
// Assign node num based on Distribution node
for (int i = 1; i <= AirflowNetworkNumOfLinks; ++i) {
for (int k = 1; k <= DisSysNumOfNodes; ++k) {
if (Util::SameString(AirflowNetworkLinkageData(i).NodeNames[0], DisSysNodeData(k).Name)) {
AirflowNetworkLinkageData(i).NodeNums[0] = k;
for (int l = 1; l <= DisSysNumOfNodes; ++l) {
if (Util::SameString(AirflowNetworkLinkageData(i).NodeNames[0], DisSysNodeData(l).Name)) {
Copy link
Copy Markdown
Collaborator Author

@dareumnam dareumnam May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This local k declared inside a nested block that shadows the outer function-level k. Rename the inner one to something more descriptive to avoid the shadow.

AirflowNetworkLinkageData(i).NodeNums[0] = l;
}
if (Util::SameString(AirflowNetworkLinkageData(i).NodeNames[1], DisSysNodeData(k).Name)) {
AirflowNetworkLinkageData(i).NodeNums[1] = k;
if (Util::SameString(AirflowNetworkLinkageData(i).NodeNames[1], DisSysNodeData(l).Name)) {
AirflowNetworkLinkageData(i).NodeNums[1] = l;
}
}
if (AirflowNetworkLinkageData(i).NodeNums[0] == 0) {
Expand Down
2 changes: 1 addition & 1 deletion src/EnergyPlus/BaseboardRadiator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,8 @@ namespace BaseboardRadiator {
static constexpr std::string_view availabilityScheduleFieldName = "Availability Schedule Name";
static constexpr std::string_view heatingDesignCapacityMethodFieldName = "Heating Design Capacity Method";

int ConvHWBaseboardNum = 0;
if (baseboardObjects != inputProcessor->epJSON.end()) {
int ConvHWBaseboardNum = 0;
Copy link
Copy Markdown
Collaborator Author

@dareumnam dareumnam May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConvHWBaseboardNum is declared outside the if block but only used inside the for loop. Just move the declaration inside the if block to tighten the scope. No logic change needed.

for (auto const &baseboardInstance : baseboardObjects.value().items()) {
auto const &baseboardFields = baseboardInstance.value();
auto const baseboardName = Util::makeUPPER(baseboardInstance.key());
Expand Down
2 changes: 1 addition & 1 deletion src/EnergyPlus/BoilerSteam.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,8 @@ namespace BoilerSteam {
auto const &boilerSchemaProps = inputProcessor->getObjectSchemaProps(state, state.dataIPShortCut->cCurrentModuleObject);
auto const boilerObjects = inputProcessor->epJSON.find(state.dataIPShortCut->cCurrentModuleObject);

int BoilerNum = 1;
if (boilerObjects != inputProcessor->epJSON.end()) {
int BoilerNum = 1;
Copy link
Copy Markdown
Collaborator Author

@dareumnam dareumnam May 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as the ConvHWBaseboardNum case. BoilerNum is declared outside the if block but only used inside the for loop within it. Just move the declaration inside the if block to tighten the scope. Easy fix, no logic change needed.

for (auto const &boilerInstance : boilerObjects.value().items()) {
auto const &boilerFields = boilerInstance.value();
auto const boilerName = Util::makeUPPER(boilerInstance.key());
Expand Down
2 changes: 1 addition & 1 deletion src/EnergyPlus/EMSManager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ namespace EMSManager {
state.dataRuntimeLang->NumExternalInterfaceFunctionalMockupUnitImportActuatorsUsed +
state.dataRuntimeLang->NumExternalInterfaceFunctionalMockupUnitExportActuatorsUsed;
++ActuatorUsedLoop) {
auto &thisActuatorUsed = state.dataRuntimeLang->EMSActuatorUsed(ActuatorUsedLoop);
auto const &thisActuatorUsed = state.dataRuntimeLang->EMSActuatorUsed(ActuatorUsedLoop);

int ErlVariableNum = thisActuatorUsed.ErlVariableNum;
if (ErlVariableNum <= 0) {
Expand Down
2 changes: 1 addition & 1 deletion src/EnergyPlus/ElectricBaseboardRadiator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,8 @@ namespace ElectricBaseboardRadiator {
static constexpr std::string_view radiantSurfaceFractionFieldName = "Fraction of Radiant Energy to Surface";
auto const &surfaceFractionSchemaProps = elecBaseboardSchemaProps.at("surface_fractions").at("items").at("properties");

int BaseboardNum = 0;
if (elecBaseboardObjects != inputProcessor->epJSON.end()) {
int BaseboardNum = 0;
Copy link
Copy Markdown
Collaborator Author

@dareumnam dareumnam May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

for (auto const &elecBaseboardInstance : elecBaseboardObjects.value().items()) {
auto const &elecBaseboardFields = elecBaseboardInstance.value();
auto const elecBaseboardName = Util::makeUPPER(elecBaseboardInstance.key());
Expand Down
2 changes: 1 addition & 1 deletion src/EnergyPlus/FileSystem.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ namespace FileSystem {
// *
// * To resolve symlinks, wrap this call in getAbsolutePath().
// */
char executableRelativePath[1024];
char executableRelativePath[1024] = {'\0'};

#ifdef __APPLE__
uint32_t pathSize = sizeof(executableRelativePath);
Expand Down
1 change: 0 additions & 1 deletion src/EnergyPlus/Furnaces.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,6 @@ namespace Furnaces {
if (errorFound) {
ShowSevereError(state, EnergyPlus::format("The index of \"{}\" is not found", thisFurnace.SuppHeatCoilName));
ShowContinueError(state, EnergyPlus::format("...occurs for {}", thisFurnace.Name));
errorFound = false;
Copy link
Copy Markdown
Collaborator Author

@dareumnam dareumnam May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last errorFound = false at the end of the suppHeatCoil error block is a dead assignment since the function returns right after and errorFound is never read again. Safe to just remove that line.

}
state.dataAirLoop->AirLoopAFNInfo(AirLoopNum).AFNLoopHeatingCoilMaxRTF =
max(refAFNLoopHeatingCoilMaxRTF, heatingCoilRTF, suppHeatingCoilRTF);
Expand Down
2 changes: 1 addition & 1 deletion src/EnergyPlus/HVACDXHeatPumpSystem.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1116,7 +1116,7 @@ namespace HVACDXHeatPumpSystem {
if (state.dataHVACDXHeatPumpSys->NumDXHeatPumpSystems > 0) {
int DXHeatSysNum = Util::FindItemInList(DXHeatCoilSysName, state.dataHVACDXHeatPumpSys->DXHeatPumpSystem);
if (DXHeatSysNum > 0 && DXHeatSysNum <= state.dataHVACDXHeatPumpSys->NumDXHeatPumpSystems) {
auto &dxhpSystem = state.dataHVACDXHeatPumpSys->DXHeatPumpSystem(DXHeatSysNum);
auto const &dxhpSystem = state.dataHVACDXHeatPumpSys->DXHeatPumpSystem(DXHeatSysNum);
NodeNum = dxhpSystem.DXHeatPumpCoilInletNodeNum;
}
}
Expand Down
24 changes: 12 additions & 12 deletions src/EnergyPlus/HVACVariableRefrigerantFlow.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7326,7 +7326,7 @@ void SetCompFlowRate(EnergyPlusData &state, int const VRFTUNum, int const VRFCon
int IndexToTUInTUList; // - index to TU in specific list for this VRF system
int TUListIndex; // index to TU list for this VRF system

auto &vrfTU = state.dataHVACVarRefFlow->VRFTU(VRFTUNum);
auto const &vrfTU = state.dataHVACVarRefFlow->VRFTU(VRFTUNum);
IndexToTUInTUList = vrfTU.IndexToTUInTUList;
TUListIndex = vrfTU.TUListIndex;

Expand Down Expand Up @@ -8272,18 +8272,18 @@ void SizeVRF(EnergyPlusData &state, int const VRFTUNum)
auto &vrfTUList = state.dataHVACVarRefFlow->TerminalUnitList(TUListNum);
for (int NumTU = 1; NumTU <= vrfTUList.NumTUInList; ++NumTU) {
int TUIndex = vrfTUList.ZoneTUPtr(NumTU);
auto &vrfTU = state.dataHVACVarRefFlow->VRFTU(TUIndex);
if (vrfTU.CoolCoilIndex > 0) {
DXCoilCap = DXCoils::GetCoilCapacityByIndexType(state, vrfTU.CoolCoilIndex, vrfTU.coolCoilType, errFlag);
auto &vrfTUobj = state.dataHVACVarRefFlow->VRFTU(TUIndex);
Copy link
Copy Markdown
Collaborator Author

@dareumnam dareumnam May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfTU is declared at function scope and then shadowed inside the for loop by another vrfTU pointing to a different TU. Rename the inner one to vrfTUobj to make it clear these are different objects.

if (vrfTUobj.CoolCoilIndex > 0) {
DXCoilCap = DXCoils::GetCoilCapacityByIndexType(state, vrfTUobj.CoolCoilIndex, vrfTUobj.coolCoilType, errFlag);
TUCoolingCapacity += DXCoilCap;
if (DXCoilCap == AutoSize) {
FoundAll = false;
break;
}
}

if (vrfTU.HeatCoilIndex > 0) {
DXCoilCap = DXCoils::GetCoilCapacityByIndexType(state, vrfTU.HeatCoilIndex, vrfTU.heatCoilType, errFlag);
if (vrfTUobj.HeatCoilIndex > 0) {
DXCoilCap = DXCoils::GetCoilCapacityByIndexType(state, vrfTUobj.HeatCoilIndex, vrfTUobj.heatCoilType, errFlag);
TUHeatingCapacity += DXCoilCap;
if (DXCoilCap == AutoSize) {
FoundAll = false;
Expand Down Expand Up @@ -10455,7 +10455,7 @@ int GetVRFTUOutAirNode(EnergyPlusData &state, int const VRFTUNum)
}

if (VRFTUNum > 0 && VRFTUNum <= state.dataHVACVarRefFlow->NumVRFTU) {
auto &vrfTU = state.dataHVACVarRefFlow->VRFTU(VRFTUNum);
auto const &vrfTU = state.dataHVACVarRefFlow->VRFTU(VRFTUNum);
return vrfTU.VRFTUOAMixerOANodeNum;
}
return 0;
Expand All @@ -10479,7 +10479,7 @@ int GetVRFTUZoneInletAirNode(EnergyPlusData &state, int const VRFTUNum)
}

if (VRFTUNum > 0 && VRFTUNum <= state.dataHVACVarRefFlow->NumVRFTU) {
auto &vrfTU = state.dataHVACVarRefFlow->VRFTU(VRFTUNum);
auto const &vrfTU = state.dataHVACVarRefFlow->VRFTU(VRFTUNum);
return vrfTU.VRFTUOutletNodeNum;
}
return 0;
Expand Down Expand Up @@ -10547,7 +10547,7 @@ int GetVRFTUMixedAirNode(EnergyPlusData &state, int const VRFTUNum)
}

if (VRFTUNum > 0 && VRFTUNum <= state.dataHVACVarRefFlow->NumVRFTU) {
auto &vrfTU = state.dataHVACVarRefFlow->VRFTU(VRFTUNum);
auto const &vrfTU = state.dataHVACVarRefFlow->VRFTU(VRFTUNum);
return vrfTU.VRFTUOAMixerOANodeNum;
}
return 0;
Expand All @@ -10571,7 +10571,7 @@ int GetVRFTUReturnAirNode(EnergyPlusData &state, int const VRFTUNum)
}

if (VRFTUNum > 0 && VRFTUNum <= state.dataHVACVarRefFlow->NumVRFTU) {
auto &vrfTU = state.dataHVACVarRefFlow->VRFTU(VRFTUNum);
auto const &vrfTU = state.dataHVACVarRefFlow->VRFTU(VRFTUNum);
return vrfTU.VRFTUOAMixerRetNodeNum;
}
return 0;
Expand Down Expand Up @@ -14936,7 +14936,7 @@ void VRFCondenserEquipment::VRFOU_PipeLossC(
NumIUActivated = 0;
for (int NumTU = 1; NumTU <= NumTUInList; ++NumTU) {
int TUIndex = vrfTUList.ZoneTUPtr(NumTU);
auto &vrfTU = state.dataHVACVarRefFlow->VRFTU(TUIndex);
auto const &vrfTU = state.dataHVACVarRefFlow->VRFTU(TUIndex);
int CoilIndex = vrfTU.CoolCoilIndex;

if (state.dataDXCoils->DXCoil(CoilIndex).TotalCoolingEnergyRate > 0.0) {
Expand Down Expand Up @@ -15096,7 +15096,7 @@ void VRFCondenserEquipment::VRFOU_PipeLossH(
NumIUActivated = 0;
for (int NumTU = 1; NumTU <= NumTUInList; ++NumTU) {
int TUIndex = vrfTUList.ZoneTUPtr(NumTU);
auto &vrfTU = state.dataHVACVarRefFlow->VRFTU(TUIndex);
auto const &vrfTU = state.dataHVACVarRefFlow->VRFTU(TUIndex);
int CoilIndex = vrfTU.HeatCoilIndex;

if (state.dataDXCoils->DXCoil(CoilIndex).TotalHeatingEnergyRate > 0.0) {
Expand Down
1 change: 1 addition & 0 deletions src/EnergyPlus/HeatBalanceKivaManager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@

namespace EnergyPlus::HeatBalanceKivaManager {

// cppcheck-suppress passedByValueCallback
void kivaErrorCallback(const int messageType, const std::string message, void *contextPtr)
{
if (contextPtr == nullptr) {
Expand Down
6 changes: 2 additions & 4 deletions src/EnergyPlus/HeatBalanceSurfaceManager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5310,10 +5310,8 @@ void UpdateThermalHistories(EnergyPlusData &state)
SurfOutsideTempCurr * construct.CTFTUserOut[0] + state.dataHeatBalSurf->SurfTempIn(SurfNum) * construct.CTFTUserIn[0] +
state.dataHeatBalSurf->SurfQsrcHist(SurfNum, 1) * construct.CTFTUserSource[0] +
state.dataHeatBalFanSys->CTFTuserConstPart(SurfNum);
}

// Set current outside flux:
if (construct.SourceSinkPresent) {
// Set current outside flux:
Copy link
Copy Markdown
Collaborator Author

@dareumnam dareumnam May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second and third if (construct.SourceSinkPresent) checks are consecutive with no intervening changes to construct, so they can be merged into one.

state.dataHeatBalSurf->SurfOutsideFluxHist(1)(SurfNum) =
SurfOutsideTempCurr * construct.CTFOutside[0] - state.dataHeatBalSurf->SurfTempIn(SurfNum) * construct.CTFCross[0] +
state.dataHeatBalSurf->SurfQsrcHist(SurfNum, 1) * construct.CTFSourceOut[0] +
Expand Down Expand Up @@ -9936,7 +9934,7 @@ void InitSurfacePropertyViewFactors(EnergyPlusData &state)
}
if (Surface.IsSurfPropertyGndSurfacesDefined) {
GndSurfsNum = Surface.SurfPropertyGndSurfIndex;
auto &GrndSurfsProperty = state.dataSurface->GroundSurfsProperty(GndSurfsNum);
auto const &GrndSurfsProperty = state.dataSurface->GroundSurfsProperty(GndSurfsNum);
GroundSurfsViewFactor = GrndSurfsProperty.SurfsViewFactorSum;
IsGroundViewFactorSet = GrndSurfsProperty.IsGroundViewFactorSet;
SrdSurfsViewFactor += GroundSurfsViewFactor;
Expand Down
3 changes: 2 additions & 1 deletion src/EnergyPlus/IndoorGreen.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,8 @@ namespace IndoorGreen {
Real64 rhoair = Psychrometrics::PsyRhoAirFnPbTdbW(state, OutPb * 1000, ZonePreTemp, ZonePreHum); // kg/m3
Real64 ETRate; // mm/s; kg/(m2s)
Real64 rs = 60 * (1500 + ZonePPFD) / (200 + ZonePPFD); // stomatal resistance s/m
Real64 ra = 350 * std::pow((0.1 / 0.1), 0.5) * (1 / (LAI + 1e-10)); // aerodynamic resistance s/m
// cppcheck-suppress duplicateExpression -- room air velocity is assumed to be 0.1 m/s & mean leaf diameter is assumed to be 0.1 m
Real64 ra = 350 * std::pow((0.1 / 0.1), 0.5) * (1 / (LAI + 1e-10)); // aerodynamic resistance s/m
ETRate = (1 / hfg) * (slopepat * (In - G) + (SwitchF * rhoair * CpAir * ZoneVPD) / ra) /
(slopepat + psyconst * (1 + rs / ra)); // Penman-Monteith ET model
return ETRate; // mm/s; kg/(m2s)
Expand Down
14 changes: 7 additions & 7 deletions src/EnergyPlus/Psychrometrics.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,12 +311,12 @@ namespace Psychrometrics {

std::uint64_t hash = (Tdb_tag ^ (W_tag ^ Pb_tag)) & std::uint64_t(twbcache_size - 1);

auto &twb_Cache = state.dataPsychCache->cached_Twb;
auto &cachedTwb = state.dataPsychCache->cached_Twb;

if (twb_Cache[hash].iTdb != Tdb_tag || twb_Cache[hash].iW != W_tag || twb_Cache[hash].iPb != Pb_tag) {
twb_Cache[hash].iTdb = Tdb_tag;
twb_Cache[hash].iW = W_tag;
twb_Cache[hash].iPb = Pb_tag;
if (cachedTwb[hash].iTdb != Tdb_tag || cachedTwb[hash].iW != W_tag || cachedTwb[hash].iPb != Pb_tag) {
cachedTwb[hash].iTdb = Tdb_tag;
cachedTwb[hash].iW = W_tag;
cachedTwb[hash].iPb = Pb_tag;

DISABLE_WARNING_PUSH
DISABLE_WARNING_STRICT_ALIASING
Expand All @@ -330,10 +330,10 @@ namespace Psychrometrics {
Real64 Pb_tag_r = *reinterpret_cast<Real64 const *>(&Pb_tag);
DISABLE_WARNING_POP

twb_Cache[hash].Twb = PsyTwbFnTdbWPb_raw(state, Tdb_tag_r, W_tag_r, Pb_tag_r, CalledFrom);
cachedTwb[hash].Twb = PsyTwbFnTdbWPb_raw(state, Tdb_tag_r, W_tag_r, Pb_tag_r, CalledFrom);
}

return twb_Cache[hash].Twb;
return cachedTwb[hash].Twb;
}

Real64 PsyTwbFnTdbWPb_raw(EnergyPlusData &state,
Expand Down
4 changes: 2 additions & 2 deletions src/EnergyPlus/PythonEngine.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,10 +404,10 @@ sys.argv.append("energyplus")
for (auto &p : std::filesystem::directory_iterator(pathToPythonPackages)) {
if (p.is_directory()) {
std::string dirName = p.path().filename().string();
if (dirName.starts_with("tcl") && dirName.find('.', 0) > 0) {
if (dirName.starts_with("tcl") && dirName.find('.') != std::string::npos) {
tclConfigDir = dirName;
}
if (dirName.starts_with("tk") && dirName.find('.', 0) > 0) {
if (dirName.starts_with("tk") && dirName.find('.') != std::string::npos) {
tkConfigDir = dirName;
}
if (!tclConfigDir.empty() && !tkConfigDir.empty()) {
Expand Down
6 changes: 1 addition & 5 deletions src/EnergyPlus/RefrigeratedCase.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15204,7 +15204,6 @@ void SecondaryLoopData::CalculateSecondary(EnergyPlusData &state, int const Seco
Real64 constexpr ErrorTol(0.001); // Iterative solution tolerance

bool AtPartLoad; // Whether or not need to iterate on pump power
bool DeRate; // If true, need to derate aircoils because don't carry over unmet energy
Real64 CpBrine; // Specific heat (W/kg)
Real64 DensityBrine; // Density (kg/m3)
Real64 DiffTemp; // (C)
Expand Down Expand Up @@ -15424,10 +15423,7 @@ void SecondaryLoopData::CalculateSecondary(EnergyPlusData &state, int const Seco
} //>my large number

} else { // air coils on secondary loop, no "unmet" energy accounting, just reduce amount of cooling provided to zone by coils
DeRate = false;
if (TotalLoad > this->MaxLoad) {
DeRate = true;
}
bool DeRate = (TotalLoad > this->MaxLoad); // If true, need to derate aircoils because don't carry over unmet energy
Copy link
Copy Markdown
Collaborator Author

@dareumnam dareumnam May 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DeRate is declared way up at the top of the function(line 15207) but only used in the else block at the very bottom, and it's not even initialized at declaration. Move it into the else block and initialize inline works good and avoids the potential uninitialized read.

FinalRateCoils(
state, DeRate, SourceType::SecondarySystem, SecondaryNum, TotalLoad, this->MaxLoad); // assign case credits for coils on this loop
// Bug TotalCoolingLoad not set but used below
Expand Down
8 changes: 4 additions & 4 deletions src/EnergyPlus/SolarShading.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4172,8 +4172,8 @@ void CLIPRECT(EnergyPlusData &state, int const NS2, int const NV1, int &NV3)
// Re-populate XTEMP/YTEMP
if (NV3 > 1) {
int LastEdgeIndex = -1, incr = 0;
double cornerXs[4] = {minX, minX, maxX, maxX};
double cornerYs[4] = {minY, maxY, maxY, minY};
const double cornerXs[4] = {minX, minX, maxX, maxX};
const double cornerYs[4] = {minY, maxY, maxY, minY};
Real64 edges[4] = {minX, maxY, maxX, minY};
Real64 LastEdgeX, LastEdgeY;
for (int i = 0; i <= arrc; i++) {
Expand Down Expand Up @@ -4284,8 +4284,8 @@ void CLIPRECT(EnergyPlusData &state, int const NS2, int const NV1, int &NV3)
state.dataSolarShading->YTEMP[0] = arry[0];
}
if (NV3 == 0) {
double cornerXs[4] = {minX, minX, maxX, maxX};
double cornerYs[4] = {minY, maxY, maxY, minY};
const double cornerXs[4] = {minX, minX, maxX, maxX};
const double cornerYs[4] = {minY, maxY, maxY, minY};
Real64 cornerX = cornerXs[0];
Real64 cornerY = cornerYs[0];
bool insideFlag = true;
Expand Down
Loading
Loading