Skip to content

Fix infinite loop risk: Counter never incremented in a do-while loop #11557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dareumnam wants to merge 4 commits into
base: develop
Choose a base branch
from
+51 −15
Draft

Fix infinite loop risk: Counter never incremented in a do-while loop #11557

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ca5366
add counter increment
dareumnam Apr 30, 2026
c8c1ed9
minor refactor of VRF compressor power convergence iteration loop
mitchute May 1, 2026
89c43df
delete files
mitchute May 1, 2026
0c9b528
apply similar refactor to heating mode
mitchute May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/EnergyPlus/HVACVariableRefrigerantFlow.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11362,7 +11362,7 @@ void VRFCondenserEquipment::CalcVRFCondenser_FluidTCtrl(EnergyPlusData &state, c
Ncomp,
CyclingRatio);

converged_10 = (std::abs(Ncomp - Ncomp_new) <= (Tolerance * Ncomp_new)) || (Counter >= 30);
converged_10 = (std::abs(Ncomp - Ncomp_new) <= (Tolerance * Ncomp_new)) || (Counter++ >= 30);
if (!converged_10) {
Ncomp_new = Ncomp;
}
Expand Down Expand Up @@ -11581,8 +11581,7 @@ void VRFCondenserEquipment::CalcVRFCondenser_FluidTCtrl(EnergyPlusData &state, c
Ncomp_new,
CyclingRatio);

converged_20 = (std::abs(Ncomp_new - Ncomp) <= (Tolerance * Ncomp)) || (Counter >= 30);
Counter = Counter + 1;
converged_20 = (std::abs(Ncomp_new - Ncomp) <= (Tolerance * Ncomp)) || (Counter++ >= 30);
Copy link
Copy Markdown
Collaborator

@rraustad rraustad Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks so nice.

if (!converged_20) {
Ncomp = Ncomp_new;
}
Expand Down
Loading