Skip to content

Fix WindowProperty:FrameAndDivider IDD and docs issues#11538

Open
joseph-robertson wants to merge 8 commits into
developfrom
window-prop-dividers
Open

Fix WindowProperty:FrameAndDivider IDD and docs issues#11538
joseph-robertson wants to merge 8 commits into
developfrom
window-prop-dividers

Conversation

@joseph-robertson
Copy link
Copy Markdown
Collaborator

@joseph-robertson joseph-robertson commented Apr 23, 2026

Pull request overview

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@joseph-robertson joseph-robertson self-assigned this Apr 23, 2026
@joseph-robertson joseph-robertson added Defect Includes code to repair a defect in EnergyPlus IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) labels Apr 23, 2026
@github-actions
Copy link
Copy Markdown

⚠️ Regressions detected on ubuntu-24.04 for commit fc86c8e

Regression Summary
  • ESO Small Diffs: 706
  • Table Small Diffs: 392
  • MTR Small Diffs: 524
  • Table String Diffs: 177
  • EIO: 397
  • JSON Small Diffs: 2
  • ZSZ Small Diffs: 72
  • Table Big Diffs: 36
  • ERR: 14
  • MTR Big Diffs: 2
  • ESO Big Diffs: 10
  • SSZ Small Diffs: 13
  • EDD: 4
  • JSON Big Diffs: 2

@joseph-robertson
Copy link
Copy Markdown
Collaborator Author

Every test file with WindowProperty:FrameAndDivider has a hard-assigned value for Frame Conductance. Value 5.0 seems to be a pretty popular choice.

@joseph-robertson joseph-robertson changed the title Fix WindowProperty:FrameAndDivider IDD issues Fix WindowProperty:FrameAndDivider IDD and docs issues May 13, 2026
@joseph-robertson joseph-robertson added the Documentation Related primarily on the LaTeX-based EnergyPlus documentation label May 13, 2026
EXPECT_EQ(state->dataSurface->SurfWinFrameEdgeArea(1), state->dataSurface->SurfWinFrameEdgeArea(2));
EXPECT_NE(state->dataSurface->SurfWinFrameEdgeArea(1), state->dataSurface->SurfWinFrameEdgeArea(3));
EXPECT_NE(state->dataSurface->SurfWinFrameEdgeArea(2), state->dataSurface->SurfWinFrameEdgeArea(3));
}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a while to realize that HorDividers and VertDividers are now int and that's why there is truncation.

@joseph-robertson joseph-robertson marked this pull request as ready for review May 13, 2026 20:09
Comment on lines +6820 to +6821
frameDivider2.HorDividers = 2.25;
frameDivider2.VertDividers = 2.99;
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mac catches these. Should we just delete this test, now that we've demonstrated the truncation and updated the IDD? Or maybe somehow wrap this so it slides for Mac?

@mitchute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus Documentation Related primarily on the LaTeX-based EnergyPlus documentation IDDChange Code changes impact the IDD file (cannot be merged after IO freeze)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WindowProperty:FrameAndDivider IDD missing either required-field or default value

4 participants