-
Notifications
You must be signed in to change notification settings - Fork 92
Support 1.21.4 #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 1.21.4 #104
Conversation
|
Where did you find a fully prepared snbt codec file for 1.21.4? Because of this I had difficulties updating to 1.21.4 and I was going to send completely different registers to the client, as the vanilla server does |
|
I did not find one, just hacked something in an hour until it worked. This may be totally incomplete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This packet is called ClientSettings and in this particular case there seems to be no point in decoding it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did you find the name of ClientSettings? Is there documentation available on this new packet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not long ago, the popular wiki for minecraft protocol - wiki.vg was closed, but the information is transferred to a new wiki here:
https://minecraft.wiki/w/Minecraft_Wiki:Projects/wiki.vg_merge/Protocol
The packet with the number 0x00 in the configuration phase of Serverbound is a ClientSettings packet, in addition to the fact that it has a locale field, your packet is missing 8 more fields.
And as I already said, decoding this packet is not required at all
|
I'm looking forward to this becoming stable. You can refer to the other Limbo github: |
|
It is going to take some time to rewrite all of this manually from the other Limbo... |
|
If you don't mind, I can do the upgrade to 1.21.4 myself in my branch using a different approach and using different registers (without using snbt for the most part) At this point all that is required to update to 1.21.4 is to update the mappings to 1.21.4 and the snbt codec. I am going to ditch the current codecs in favor of what the truly vanilla server sends to the client. |
|
Sure, go ahead! I will close this PR once you're done. |
This pull requests is based on the work from @BoomEaro in their pull request #98
The PR #98 should be merged before this one.
As the protocol wiki is not updated yet to 1.21.4, I may be missing some things.