Skip to content

fix: disable use_bool_op in objective c (#32) #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Curve
Copy link

@Curve Curve commented Aug 17, 2024

@Naios


What was a problem?

See #32

How this PR fixes the problem?

This PR disables use_bool_op when Objective C is detected.

I would appreciate some help to to update this PR to a more robust implementation though.
I've written a small POC that adds an additional check to has_bool_op that fails when the given type is convertible to a block-pointer: https://godbolt.org/z/GhM63xYnd

The implementation seen above is not implemented in this PR as I've used std::function to deduce the return and parameter types. I tried to do this with the function_trait found in the library, however, it does not seem to cover lambdas ootb, so I figured I might ask here first before modifying function_trait.

Check lists (check x in [ ] of list items)

  • Additional Unit Tests were added that test the feature or regression
  • Coding style (Clang format was applied)

@Curve Curve requested a review from Naios as a code owner August 17, 2024 16:07
@Naios
Copy link
Owner

Naios commented Dec 24, 2024

@Curve This PR got lost in my notifications. I will look at it in the following days. Please ping me again otherwise.

@Curve
Copy link
Author

Curve commented Dec 24, 2024

@Curve This PR got lost in my notifications. I will look at it in the following days. Please ping me again otherwise.

Thanks! I totally forgot I made this PR, I've made a new PR as I polluted the branch used for this PR with other changes and couldn't change the down-stream branch for the PR :)
See #64

@Curve Curve closed this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants