Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the missing index buffer offset for skinned mesh instance. #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HanetakaChou
Copy link
Contributor

 // ...

 for (const auto& skinnedInstance : m_SceneGraph->GetSkinnedMeshInstances())
    {
        const auto& skinnedMesh = skinnedInstance->GetMesh();

        if (!skinnedMesh->buffers)
        {
            skinnedMesh->buffers = std::make_shared<BufferGroup>();

            uint32_t totalVertices = skinnedMesh->totalVertices;

            skinnedMesh->buffers->indexBuffer = skinnedInstance->GetPrototypeMesh()->buffers->indexBuffer;
            skinnedMesh->buffers->indexBufferDescriptor = skinnedInstance->GetPrototypeMesh()->buffers->indexBufferDescriptor;

 // ...

According to the above code within Scene::CreateMeshBuffers, the same index buffer may be shared by different skinned meshes.

Thus, the index offset should NOT be omitted when creating the skinned mesh.

@HanetakaChou
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@HanetakaChou
Copy link
Contributor Author

@apanteleev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant