CMake variables need to be declared as CACHE for them to be changeabl… #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e by parent project
…provider - setting offsets to UINT_MAX makes them just pick up the default as if there were no shader provider.
nv-jdeligiannis
added a commit
that referenced
this pull request
Nov 18, 2024
* VK bindings can not be properly configured by cmake parent project * VK bindings can be set at runtime by shader provider in nvrhi integration layer * Thanks @fstrugar-nv ! Co-authored-by: Filip Strugar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e by parent project