Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplified diffray example #398

Merged
merged 2 commits into from
Dec 20, 2024
Merged

simplified diffray example #398

merged 2 commits into from
Dec 20, 2024

Conversation

rrzhang139
Copy link
Contributor

Category

  • New feature
  • Bugfix
  • Breaking change
  • Refactoring
  • Documentation
  • Other (please explain)

Description

Uses the barycentric coordinates obtained from wp.mesh_query_ray instead of manual calculation.

Changelog

  • Removed manual calculation of barycentric coordinates.

Before your PR is "Ready for review"

  • Do you agree to the terms under which contributions are accepted as described in Section 9 the Warp License?
  • Have you read the Contributor Guidelines?
  • Have you written any new necessary tests?
  • Have you added or updated any necessary documentation?
  • Have you added any files modified by compiling Warp and building the documentation to this PR (.e.g. stubs.py, functions.rst)?
  • Does your code pass ruff check and ruff format --check?

@shi-eric shi-eric requested a review from daedalus5 December 17, 2024 01:15
@cadop
Copy link
Contributor

cadop commented Dec 17, 2024

fwiw, I personally like the verbose method since it helps me understand it.

Copy link
Contributor

@daedalus5 daedalus5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a net-positive change. It simplifies the example and better demonstrates API usage.

@shi-eric shi-eric merged commit 048587d into NVIDIA:main Dec 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants