Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependabot update for CUDA base images #22

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

cdesiniotis
Copy link
Contributor

No description provided.

@tariq1890
Copy link
Contributor

I believe there is a way to have dependabot increment the environment variable based on the latest image tag available.

Let's pursue that option if possible. That way, we wouldn't have to make too changes to the existing scripts

@elezar
Copy link
Member

elezar commented Apr 11, 2024

I believe there is a way to have dependabot increment the environment variable based on the latest image tag available.

Let's pursue that option if possible. That way, we wouldn't have to make too changes to the existing scripts

If you have a way to do this, then that would be preferred. For this case, specifying the version and the dist directly is redundant since we only produce a single image flavour in any case. The priority here is ensuring that the base images are up to date and not maintaining the existing scripts -- unless the functionality is actually used.

Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cdesiniotis. With @tariq1890's comments noted, I still think this is a worthwhile change as it removes a manual and specifically mechanical step from what is required to keep our images up to date.

If we do have a way to so this in the context of the existing logic, I'd be happy to consider that too. For now, this looks good though.

@tariq1890
Copy link
Contributor

Looks like what I said possible in renovate bot. More details here: https://docs.renovatebot.com/modules/manager/regex/

Not sure if dependabot has a similar feature. Definitely worth investigating.

FYI - My comments aren't blocking

@elezar elezar merged commit d370ddf into NVIDIA:main Apr 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants