Silencing clang-tidy warnings #1551
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Silencing `readability-static-accessed-through-instance` by removing static from function declaration - Silencing "Assigned value is garbage or undefined": - Properly initialize vtable - Disabling some code when run under clang-tidy
sithhell
added a commit
to olympus-robotics/hephaestus
that referenced
this pull request
Jun 18, 2025
- Adding `repeatUntil` that allows non copyable senders (by allowing factories), needed in combination with `exec::task<>` - Silencing clang-tidy based errors with coroutines (the patch can be removed once NVIDIA/stdexec#1551 is resolved)
4 tasks
sithhell
added a commit
to olympus-robotics/hephaestus
that referenced
this pull request
Jun 19, 2025
- Adding `repeatUntil` that allows non copyable senders (by allowing factories), needed in combination with `exec::task<>` - Silencing clang-tidy based errors with coroutines (the patch can be removed once NVIDIA/stdexec#1551 is resolved)
ericniebler
reviewed
Jun 20, 2025
Comment on lines
-323
to
333
| static constexpr auto await_ready() noexcept -> bool { | ||
| constexpr auto await_ready() noexcept -> bool { | ||
| return false; | ||
| } | ||
|
|
||
| static auto await_suspend(__coro::coroutine_handle<__promise> __h) noexcept | ||
| auto await_suspend(__coro::coroutine_handle<__promise> __h) noexcept | ||
| -> __coro::coroutine_handle<> { | ||
| return __h.promise().continuation().handle(); | ||
| } | ||
|
|
||
| static void await_resume() noexcept { | ||
| void await_resume() noexcept { | ||
| } |
There was a problem hiding this comment.
the code is correct. these functions do not need to be passed a this pointer, hence the static. is there a way to suppress this warning locally?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readability-static-accessed-through-instanceby removing static from function declaration