Skip to content

sequence: relax iterate to support ranges::input_range #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
petertran858 wants to merge 4 commits into from
Closed

sequence: relax iterate to support ranges::input_range #1547

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
55acb82
sequence: relax iterate to support ranges::input_range
petertran858 Jun 11, 2025
f73723c
change `__item_iteration` to support input iterators
ericniebler Jun 26, 2025
e02ecf6
Merge remote-tracking branch 'origin/main' into seq-iterate-forward-r…
ericniebler Jun 26, 2025
9e83af9
do not access member of opstate after call to `set_value`
ericniebler Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions include/exec/sequence/iterate.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@ namespace exec {
__operation_base<_Iterator, _Sentinel>* __parent_;

void start() & noexcept {
stdexec::set_value(static_cast<_ItemRcvr&&>(__rcvr_), *__parent_->__iterator_++);
auto& __iter = __parent_->__iterator_;
stdexec::set_value(static_cast<_ItemRcvr&&>(__rcvr_), *__iter);
++__iter;
}
};
};
Expand Down Expand Up @@ -125,7 +127,6 @@ namespace exec {
if (this->__iterator_ == this->__sentinel_) {
stdexec::set_value(static_cast<_Receiver&&>(__rcvr_));
} else {

STDEXEC_TRY {
stdexec::start(__op_.emplace(__emplace_from{[&] {
return stdexec::connect(
Expand Down Expand Up @@ -163,7 +164,7 @@ namespace exec {
};

struct iterate_t {
template <std::ranges::forward_range _Range>
template <std::ranges::input_range _Range>
requires __decay_copyable<_Range>
auto operator()(_Range&& __range) const {
return make_sequence_expr<iterate_t>(__decay_t<_Range>{static_cast<_Range&&>(__range)});
Expand Down
Loading