Revert "Follow Up: Make '--platform' argument mandatory in CLI (#1473)" #1498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1497.
In #1472, the
--platform
argument was made a required parameter in Fire. In our tests, it was found that the short flag -p for platform is no longer functioning.Upon investigation, it seems that Fire does not support short flags for required arguments.
This PR reverts the above commit and makes the platform argument optional in Fire. This change will ensure compatibility with the -p flag.
The platform argument will still be validated internally to ensure its requirement is enforced.
Case 1 : Platform not provided
STDOUT
Case 2: Platform provided by
--platform
and-p
STDOUT