Add zero copy data writer for kudo. #2763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liurenjie1024
changed the title
Signed-off-by: Renjie Liu <[email protected]>
liurenjie1024
force-pushed
the
ray/half-zero-copy
branch
from
73645c3 to
606e935
Compare
|
build |
binmahone
reviewed
Jan 21, 2025
| * | ||
| * <br/> | ||
| * | ||
| * This code is copied from jdk's implementation. |
There was a problem hiding this comment.
should we state at the begining of the class that most of the class code is copied from jdk, and highlight what is added on ? for both copywrite and mainenance considerations
revans2
requested changes
Jan 21, 2025
There was a problem hiding this comment.
"This code is copied from jdk's implementation."
This is a violation of java's license.
https://openjdk.org/legal/gplv2+ce.html
GPLv2 is not compatible with Apache 2.0 and no code from the java standard library can be included in this project ever.
|
Closing this PR as will not merge. @liurenjie1024 please redo without GPL code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reservemethod inDataWriterso that kudo data writer could reserve memory before actual writing happens. This helps avoiding unnecessay allocation and copy.OpenByteArrayOutputStreamand its corresponding data writer.OpenByteArrayOutputStreamcould be used in customized shuffle manager to save memory.ByteArrayOutputStreamWriterwhich helps saving memory copy without introducing any changes to shuffle manager.