A few fixes for the domino pipeline. #863
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- initialize the distributed manager, if it isn't already. - For partial datasets (surface only, volumen only) don't move "None" objects to cupy. - When sampling/shuffling, if the number of points is too high then don't error. Instead, shuffle and rely on padding.
| @@ -314,15 +314,16 @@ def pad_inp(arr: ArrayType, npoin: int, pad_value: float = 0.0) -> ArrayType: | |||
| return arr_padded | |||
|
|
|||
|
|
|||
| # CJA NOTE: the `sample_array` function is the same optimization I put into shuffle_array. | |||
| # Keeping the cupy compatible version (mine) | |||
| @profile | |||
There was a problem hiding this comment.
Is keeping the @profile decorator intended?
There was a problem hiding this comment.
Its harmless, I put those in to see whats expensive. On the gpu its useless, with numpy it's useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
Checklist
Dependencies