Gating on Datapipes - prototype #861
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- check_package_installed will return a simple bool if a package is installed or not. - use check_min_version to require a minimum installed version. - the __init__.py file in physicsnemo/datapipes/cae now wraps both datapipes in a function. - python 3.7 enabled __getattr__ at module level. (https://peps.python.org/pep-0562/) - this function now performs requirement checking on these imports before returning. - If an import fails, it will print an informative message about it in the ImportError.
|
/blossom-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new, small functionality to physicsnemo's version check tools, to see if a package is installed.
Then, the import of the datapipes leverages this tool to prevent missing imports from Domino datapipe (and the other way, if vtk is missing or broken, don't let mesh datapipe prevent domino datapipe.)
Some details:
Closes #847
ADDITIONALLY
This fixes an error I encountered in the pyproject.toml license listing. We should check this carefully before merging. Passing
license="Apache 2.0"did not work, but passinglicense={file="LICENSE.txt"}appears to work.PhysicsNeMo Pull Request
Description
Checklist
Dependencies