-
Notifications
You must be signed in to change notification settings - Fork 322
Backward compatibility for corrdiff checkpoints #857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Backward compatibility for corrdiff checkpoints #857
Conversation
Signed-off-by: Charlelie Laurent <[email protected]>
Signed-off-by: Charlelie Laurent <[email protected]>
/blossom-ci |
Signed-off-by: Charlelie Laurent <[email protected]>
/blossom-ci |
@pzharrington
So, I proposed another refactor that does essentially the same thing, but that is enabled by a keyword argument passed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the keyword arg to toggle backward compat mode in from_checkpoint
provides a reasonable degree of safety, having users need to opt into loading an older checkpoint which is good.
PhysicsNeMo Pull Request
Description
This PR introduces a patch to be able to load existing UNet and SongUNet checkpoints, similar to those used in CorrDiff.
To apply backward compatibility patches and be able to load old checkpoints, run:
Bu default
backward_compatibility=False
, in which case the checkpoint loader will raise an error when attempting to load an old checkpoint.Checklist
Dependencies
None.