[no-relnote] Configure all GitHub actions as reusable workflow #915
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| # Copyright 2025 NVIDIA CORPORATION | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| name: CI Pipeline | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - "pull-request/[0-9]+" | ||
| - main | ||
| - release-* | ||
|
|
||
| jobs: | ||
| code-scanning: | ||
| uses: ./.github/workflows/code_scanning.yaml | ||
|
|
||
| variables: | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| version: ${{ steps.version.outputs.version }} | ||
| steps: | ||
| - name: Generate Commit Short SHA | ||
| id: version | ||
| run: echo "version=$(echo $GITHUB_SHA | cut -c1-8)" >> "$GITHUB_OUTPUT" | ||
|
|
||
| golang: | ||
| uses: ./.github/workflows/golang.yaml | ||
|
|
||
| image: | ||
| uses: ./.github/workflows/image.yaml | ||
| needs: [variables, golang, code-scanning] | ||
| secrets: inherit | ||
| with: | ||
| version: ${{ needs.variables.outputs.version }} | ||
| build_multi_arch_images: ${{ github.ref_name == 'main' || startsWith(github.ref_name, 'release-') }} | ||
|
|
||
| e2e-test: | ||
| needs: [image, variables] | ||
| secrets: inherit | ||
| uses: ./.github/workflows/e2e.yaml | ||
| with: | ||
| version: ${{ needs.variables.outputs.version }} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,11 +16,14 @@ | |
| name: image | ||
|
|
||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| version: | ||
| required: true | ||
| type: string | ||
| build_multi_arch_images: | ||
| required: true | ||
| type: string | ||
|
|
||
| jobs: | ||
| packages: | ||
|
|
@@ -46,20 +49,25 @@ jobs: | |
| - ispr: true | ||
| target: centos8-ppc64le | ||
| fail-fast: false | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| name: Check out code | ||
|
|
||
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@v3 | ||
| with: | ||
| image: tonistiigi/binfmt:master | ||
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
|
|
||
| - name: build ${{ matrix.target }} packages | ||
| run: | | ||
| sudo apt-get install -y coreutils build-essential sed git bash make | ||
| echo "Building packages" | ||
| ./scripts/build-packages.sh ${{ matrix.target }} | ||
|
|
||
| - name: 'Upload Artifacts' | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
|
|
@@ -84,24 +92,15 @@ jobs: | |
| steps: | ||
| - uses: actions/checkout@v4 | ||
| name: Check out code | ||
|
There was a problem hiding this comment. What version is checked out here? Should we align this with the short sha? There was a problem hiding this comment. would make sense in a follow-up PR. The defaults are ok, but moving forward when writing more reusable workflows, it will make more sense https://github.com/actions/checkout?tab=readme-ov-file#usage There was a problem hiding this comment. Shure. Could you please clarify which verison is checked out by default. There was a problem hiding this comment. # The branch, tag or SHA to checkout. When checking out the repository that
# triggered a workflow, this defaults to the reference or SHA for that event.
# Otherwise, uses the default branch.There was a problem hiding this comment. What I mean is, if this is triggered by a workflow call, is the SHA that is checked out the current version in the PR, or the SHA of the default branch. There was a problem hiding this comment. is the SHA of the commit that triggered the action, unregarding of the branch (that's why copy-pr-bot works) |
||
|
|
||
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@v3 | ||
| with: | ||
| image: tonistiigi/binfmt:master | ||
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
|
|
||
| - name: Get built packages | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
|
|
@@ -115,16 +114,13 @@ jobs: | |
| registry: ghcr.io | ||
| username: ${{ github.actor }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Build image | ||
| env: | ||
| IMAGE_NAME: ghcr.io/nvidia/container-toolkit | ||
| VERSION: ${{ inputs.version }} | ||
| PUSH_ON_BUILD: "true" | ||
| BUILD_MULTI_ARCH_IMAGES: ${{ inputs.build_multi_arch_images }} | ||
| run: | | ||
| echo "${VERSION}" | ||
| make -f deployments/container/Makefile build-${{ matrix.dist }} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the following work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, it doesn't
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a matter of interest, what error does it give? Do we have a reference of which functions are available to us? We do use
startsWith, for example.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#functions