[no-relnote] fix step holodeck_public_dns_name variable name E2E #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
reviewed
Feb 6, 2025
.github/workflows/e2e.yaml
Outdated
| @@ -71,7 +71,7 @@ jobs: | |||
| echo "$SSH_KEY" > "$e2e_ssh_key" | |||
| chmod 600 "$e2e_ssh_key" | |||
| export E2E_SSH_KEY="$e2e_ssh_key" | |||
| export E2E_SSH_HOST="${{ steps.get_public_dns_name.outputs.result }}" | |||
| export E2E_SSH_HOST="${{ steps.holodeck_public_dns_name.outputs.result }}" | |||
There was a problem hiding this comment.
Question: Could we set this in the env section instead?
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
ArangoGutierrez
force-pushed
the
reg_test07
branch
from
4dfa766 to
82ccae2
Compare
|
/ok-to-test |
In order for E2E to run during PR's we might need to change |
Does pr-bot not trigger a push? |
we need to remove this bit |
Signed-off-by: Evan Lezar <[email protected]>
elezar
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.