Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add reranker to search #381

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add reranker to search #381

wants to merge 4 commits into from

Conversation

jperez999
Copy link
Collaborator

Description

Adds an option to activate the nvidia reranker to search functionality.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jperez999 jperez999 added the feature request New feature or request label Jan 28, 2025
@jperez999 jperez999 self-assigned this Jan 28, 2025
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 28, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@jperez999 jperez999 requested review from jdye64, drobison00, randerzander, ChrisJar and edknv and removed request for jdye64 January 28, 2025 04:41
randerzander
randerzander requested changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@randerzander randerzander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reranker NIM should be under the "retrieval" profile in docker-compose, so that it's not on by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drobison00 drobison00 drobison00 approved these changes

@ChrisJar ChrisJar Awaiting requested review from ChrisJar

@jdye64 jdye64 Awaiting requested review from jdye64

@edknv edknv Awaiting requested review from edknv

@randerzander randerzander Awaiting requested review from randerzander

Assignees

@jperez999 jperez999

Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jperez999 @randerzander @drobison00