Add Github Actions #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArangoGutierrez
force-pushed
the
actions
branch
from
b1b9cd5 to
61ac620
Compare
|
Can't see why the actions won't trigger.... |
ArangoGutierrez
force-pushed
the
actions
branch
2 times, most recently
from
930aef3 to
0258852
Compare
|
@elezar any clue what am I missing here? |
elezar
reviewed
Jan 30, 2024
|
@shivamerla any update on moving https://gitlab.com/nvidia/cloud-native/k8s-kata-manager/-/merge_requests/32 to GitHub |
ArangoGutierrez
added
the
testing
ArangoGutierrez
force-pushed
the
actions
branch
from
5650243 to
042c1f9
Compare
|
PR is good to move forward |
elezar
reviewed
Feb 28, 2024
| -v $(PWD):$(PWD) \ | ||
| -w $(PWD) \ | ||
| -e GOCACHE=/tmp/.cache/go \ | ||
| -e GOMODCACHE=/tmp/.cache/gomod \ |
There was a problem hiding this comment.
I've noticed that we technically need to specify a golangci-lint cache here too.
There was a problem hiding this comment.
we run golangci-lint directly from it's action, this make target is mostly for build
There was a problem hiding this comment.
Yes, but if I want to run golangci-lint after starting an interactive shell with make .shell.
ArangoGutierrez
force-pushed
the
actions
branch
from
042c1f9 to
b959965
Compare
ArangoGutierrez
force-pushed
the
actions
branch
from
b959965 to
e643642
Compare
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> Signed-off-by: Evan Lezar <[email protected]>
ArangoGutierrez
force-pushed
the
actions
branch
from
e643642 to
fe041e3
Compare
elezar
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.