-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[no-relnote] Improve helm chart documentation #261
Open
faganihajizada
wants to merge
6
commits into
NVIDIA:main
Choose a base branch
from
faganihajizada:helm-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+215
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add helm-docs workflow to auto-generate README.md for helm charts.
Chart.yaml is updated with the correct description Signed-off-by: faganihajizada <[email protected]>
The controller is designed to run as a single instance per cluster. Please avoid running multiple instances of the controller in the same cluster at same time. Signed-off-by: faganihajizada <[email protected]>
Signed-off-by: faganihajizada <[email protected]>
Maybe also mention #257 ? |
sure @ArangoGutierrez. Do you want me to add it to the README template? feel free to commit to this PR directly if you want to. |
As part of NVIDIA#257 a new script introduced for building helm charts for release. This commit adds documentation for the script. Signed-off-by: faganihajizada <[email protected]>
@ArangoGutierrez since #257 is merged, I added it to the README. Please take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GitHub action to auto-generate README file with Helm-docs